Fix for TraceableAuthenticator debug when no Auth

PhilETaylor · PhilETaylor · commit c99762417401 · 2023-09-10T16:10:57.000+01:00
diff --git a/src/Symfony/Component/Security/Http/Authenticator/Debug/TraceableAuthenticator.php b/src/Symfony/Component/Security/Http/Authenticator/Debug/TraceableAuthenticator.php
@@ -54,7 +54,7 @@ static function (BadgeInterface $badge): array {
                         'resolved' => $badge->isResolved(),
                     ];
                 },
-                $this->passport->getBadges(),
+                $this->passport?->getBadges() ?? [],
             ),
         ];
     }
diff --git a/src/Symfony/Component/Security/Http/Tests/Authenticator/Debug/TraceableAuthenticatorTest.php b/src/Symfony/Component/Security/Http/Tests/Authenticator/Debug/TraceableAuthenticatorTest.php
@@ -36,4 +36,14 @@ public function testGetInfo()
         $this->assertSame($passport, $traceable->authenticate($request));
         $this->assertSame($passport, $traceable->getInfo()['passport']);
     }
+
+    public function testGetInfoWithoutAuth()
+    {
+        $authenticator = $this->createMock(AuthenticatorInterface::class);
+
+        $traceable = new TraceableAuthenticator($authenticator);
+        $this->assertNull( $traceable->getInfo()['passport']);
+        $this->assertIsArray( $traceable->getInfo()['badges']);
+        $this->assertSame( [], $traceable->getInfo()['badges']);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ static function (BadgeInterface $badge): array {`
`54`	`54`	`'resolved' => $badge->isResolved(),`
`55`	`55`	`];`
`56`	`56`	`},`
`57`		`- $this->passport->getBadges(),`
	`57`	`+ $this->passport?->getBadges() ?? [],`
`58`	`58`	`),`
`59`	`59`	`];`
`60`	`60`	`}`