feature #61067 [Ldap] remove the sizeLimit option of AbstractQuery (xabbuh)

nicolas-grekas · nicolas-grekas · commit ccdf41bd9644 · 2025-07-09T07:42:04.000+02:00
This PR was merged into the 8.0 branch. Discussion ---------- [Ldap] remove the `sizeLimit` option of `AbstractQuery` | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | | License | MIT Commits ------- 33094fe remove the sizeLimit option
diff --git a/UPGRADE-8.0.md b/UPGRADE-8.0.md
@@ -237,6 +237,7 @@ Intl
 Ldap
 ----
 
+ * Remove the `sizeLimit` option of `AbstractQuery`
  * Remove `LdapUser::eraseCredentials()` in favor of `__serialize()`
 
 Mailer
diff --git a/src/Symfony/Component/Ldap/Adapter/AbstractQuery.php b/src/Symfony/Component/Ldap/Adapter/AbstractQuery.php
@@ -31,7 +31,6 @@ public function __construct(
         $resolver->setDefaults([
             'filter' => '*',
             'maxItems' => 0,
-            'sizeLimit' => 0,
             'timeout' => 0,
             'deref' => static::DEREF_NEVER,
             'attrsOnly' => 0,
@@ -43,8 +42,6 @@ public function __construct(
 
         $resolver->setNormalizer('filter', fn (Options $options, $value) => \is_array($value) ? $value : [$value]);
 
-        $resolver->setDeprecated('sizeLimit', 'symfony/ldap', '7.2', 'The "%name%" option is deprecated and will be removed in Symfony 8.0.');
-
         $this->options = $resolver->resolve($options);
     }
 }
diff --git a/src/Symfony/Component/Ldap/CHANGELOG.md b/src/Symfony/Component/Ldap/CHANGELOG.md
@@ -4,6 +4,7 @@ CHANGELOG
 8.0
 ---
 
+ * Remove the `sizeLimit` option of `AbstractQuery`
  * Remove `LdapUser::eraseCredentials()` in favor of `__serialize()`
 
 7.3
diff --git a/src/Symfony/Component/Ldap/Tests/Adapter/AbstractQueryTest.php b/src/Symfony/Component/Ldap/Tests/Adapter/AbstractQueryTest.php

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,6 @@ public function __construct(`
`31`	`31`	`$resolver->setDefaults([`
`32`	`32`	`'filter' => '*',`
`33`	`33`	`'maxItems' => 0,`
`34`		`- 'sizeLimit' => 0,`
`35`	`34`	`'timeout' => 0,`
`36`	`35`	`'deref' => static::DEREF_NEVER,`
`37`	`36`	`'attrsOnly' => 0,`
`@@ -43,8 +42,6 @@ public function __construct(`
`43`	`42`
`44`	`43`	`$resolver->setNormalizer('filter', fn (Options $options, $value) => \is_array($value) ? $value : [$value]);`
`45`	`44`
`46`		`- $resolver->setDeprecated('sizeLimit', 'symfony/ldap', '7.2', 'The "%name%" option is deprecated and will be removed in Symfony 8.0.');`
`47`		`-`
`48`	`45`	`$this->options = $resolver->resolve($options);`
`49`	`46`	`}`
`50`	`47`	`}`