bug #57645 [Routing] Discard in-memory cache of routes when writing the file-based cache (mpdude)

derrabus · derrabus · commit cdd75956bb62 · 2024-07-04T13:13:12.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Routing] Discard in-memory cache of routes when writing the file-based cache | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #57640 | License | MIT The `Router` has a `private static ?array $cache` field that it uses to cache compiled route collections in the case that OpCache is not available to cache the file-based cache already. This is somewhat [a poor man's Opcache replacement](#57640 (comment)), useful e. g. for speedups during (functional) tests. `\Symfony\Component\Config\ResourceCheckerConfigCache::write` contains special code to make sure the OpCache will reload files after they have been written, but the `static` property kind of "hides" this feature. With this PR, the `static` cache entry is cleared as well. Commits ------- de7d884 [Router] Discard in-memory cache of routes when writing the file-based cache
diff --git a/src/Symfony/Component/Routing/Router.php b/src/Symfony/Component/Routing/Router.php
@@ -294,6 +294,7 @@ function (ConfigCacheInterface $cache) {
                 }
 
                 $cache->write($dumper->dump(), $this->getRouteCollection()->getResources());
+                unset(self::$cache[$cache->getPath()]);
             }
         );
 
@@ -325,6 +326,7 @@ function (ConfigCacheInterface $cache) {
                     $dumper = $this->getGeneratorDumperInstance();
 
                     $cache->write($dumper->dump(), $this->getRouteCollection()->getResources());
+                    unset(self::$cache[$cache->getPath()]);
                 }
             );
 

Original file line number	Diff line number	Diff line change
`@@ -294,6 +294,7 @@ function (ConfigCacheInterface $cache) {`
`294`	`294`	`}`
`295`	`295`
`296`	`296`	`$cache->write($dumper->dump(), $this->getRouteCollection()->getResources());`
	`297`	`+ unset(self::$cache[$cache->getPath()]);`
`297`	`298`	`}`
`298`	`299`	`);`
`299`	`300`
`@@ -325,6 +326,7 @@ function (ConfigCacheInterface $cache) {`
`325`	`326`	`$dumper = $this->getGeneratorDumperInstance();`
`326`	`327`
`327`	`328`	`$cache->write($dumper->dump(), $this->getRouteCollection()->getResources());`
	`329`	`+ unset(self::$cache[$cache->getPath()]);`
`328`	`330`	`}`
`329`	`331`	`);`
`330`	`332`