feature #52193 [PhpUnitBridge] Allow setting the locale using SYMFONY_PHPUNIT_LOCALE env var (VincentLanglet)

nicolas-grekas · nicolas-grekas · commit ce48fbe3de47 · 2023-10-27T09:51:07.000+02:00
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [PhpUnitBridge] Allow setting the locale using SYMFONY_PHPUNIT_LOCALE env var | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | yes | Deprecations? | no  | Tickets | Fix #52185 | License | MIT cc `@nicolas`-grekas Commits ------- 2954468 [PhpUnitBridge] Allow setting the locale using SYMFONY_PHPUNIT_LOCALE env var
diff --git a/src/Symfony/Bridge/PhpUnit/CHANGELOG.md b/src/Symfony/Bridge/PhpUnit/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+6.4
+---
+
+ * Allow setting the locale using `SYMFONY_PHPUNIT_LOCALE` env var
+
 6.3
 ---
 
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php b/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
@@ -50,6 +50,8 @@ class SymfonyTestsListenerTrait
      */
     public function __construct(array $mockedNamespaces = [])
     {
+        setlocale(\LC_ALL, $_ENV['SYMFONY_PHPUNIT_LOCALE'] ?? 'C');
+
         if (class_exists(ExcludeList::class)) {
             (new ExcludeList())->getExcludedDirectories();
             ExcludeList::addDirectory(\dirname((new \ReflectionClass(__CLASS__))->getFileName(), 2));
diff --git a/src/Symfony/Bridge/PhpUnit/bootstrap.php b/src/Symfony/Bridge/PhpUnit/bootstrap.php
@@ -29,9 +29,6 @@
     unset($GLOBALS['__composer_autoload_files'][$fileIdentifier]);
 }
 
-// Enforce a consistent locale
-setlocale(\LC_ALL, 'C');
-
 if (class_exists(Deprecation::class)) {
     Deprecation::withoutDeduplication();
 

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,8 @@ class SymfonyTestsListenerTrait`
`50`	`50`	`*/`
`51`	`51`	`public function __construct(array $mockedNamespaces = [])`
`52`	`52`	`{`
	`53`	`+ setlocale(\LC_ALL, $_ENV['SYMFONY_PHPUNIT_LOCALE'] ?? 'C');`
	`54`	`+`
`53`	`55`	`if (class_exists(ExcludeList::class)) {`
`54`	`56`	`(new ExcludeList())->getExcludedDirectories();`
`55`	`57`	`ExcludeList::addDirectory(\dirname((new \ReflectionClass(__CLASS__))->getFileName(), 2));`
Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,6 @@`
`29`	`29`	`unset($GLOBALS['__composer_autoload_files'][$fileIdentifier]);`
`30`	`30`	`}`
`31`	`31`
`32`		`-// Enforce a consistent locale`
`33`		`-setlocale(\LC_ALL, 'C');`
`34`		`-`
`35`	`32`	`if (class_exists(Deprecation::class)) {`
`36`	`33`	`Deprecation::withoutDeduplication();`
`37`	`34`