[DependencyInjection] Throw on attempting to set enum parameters

ogizanagi · ogizanagi · commit d2bea6a74f61 · 2022-01-26T10:57:55.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php b/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php
@@ -103,6 +103,18 @@ public function get($name)
      */
     public function set($name, $value)
     {
+        if ($value instanceof \UnitEnum) {
+            throw new \TypeError(sprintf('Enums are not supported as dependency-injection parameters. Got "%s::%s" in parameter "%s".', \get_class($value), $value->name, $name));
+        }
+
+        if (\is_array($value)) {
+            array_walk_recursive($value, static function ($value) use ($name) {
+                if ($value instanceof \UnitEnum) {
+                    throw new \TypeError(sprintf('Enums are not supported as dependency-injection parameters. Got "%s::%s" in parameter "%s".', \get_class($value), $value->name, $name));
+                }
+            });
+        }
+
         $this->parameters[(string) $name] = $value;
     }
 
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php b/src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php
@@ -16,6 +16,7 @@
 use Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException;
 use Symfony\Component\DependencyInjection\Exception\RuntimeException;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
+use Symfony\Component\DependencyInjection\Tests\Fixtures\FooUnitEnum;
 
 class ParameterBagTest extends TestCase
 {
@@ -253,4 +254,30 @@ public function stringsWithSpacesProvider()
             ['50% is less than 100%', '50% is less than 100%', 'Text between % signs is allowed, if there are spaces.'],
         ];
     }
+
+    /**
+     * @requires PHP 8.1
+     *
+     * @dataProvider provideEnumParameters
+     */
+    public function testSetEnumValueThrows($value)
+    {
+        $this->expectException(\TypeError::class);
+        $this->expectExceptionMessage('Enums are not supported as dependency-injection parameters. Got "Symfony\Component\DependencyInjection\Tests\Fixtures\FooUnitEnum::BAR" in parameter "param"');
+
+        $bag = new ParameterBag();
+
+        $bag->set('param', $value);
+    }
+
+    public function provideEnumParameters()
+    {
+        if (\PHP_VERSION_ID < 80100) {
+            return;
+        }
+
+        yield [FooUnitEnum::BAR];
+        yield [[FooUnitEnum::BAR]];
+        yield [['foo' => ['bar' => FooUnitEnum::BAR]]];
+    }
 }
