Fix

OskarStark · OskarStark · commit d89f4b531d7e · 2021-04-14T10:25:59.000+02:00
diff --git a/src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Tests/Section/ActivityFieldTest.php b/src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Tests/Section/ActivityFieldTest.php
@@ -9,33 +9,33 @@ final class ActivityFieldTest extends TestCase
 {
     public function testImage()
     {
-        $element = (new ActivityField())
+        $field = (new ActivityField())
             ->image($value = 'https://symfony.com/logo.png');
 
-        $this->assertSame($value, $element->toArray()['activityImage']);
+        $this->assertSame($value, $field->toArray()['activityImage']);
     }
 
     public function testTitle()
     {
-        $element = (new ActivityField())
+        $field = (new ActivityField())
             ->title($value = 'Symfony is great!');
 
-        $this->assertSame($value, $element->toArray()['activityTitle']);
+        $this->assertSame($value, $field->toArray()['activityTitle']);
     }
 
     public function testSubtitle()
     {
-        $element = (new ActivityField())
+        $field = (new ActivityField())
             ->subtitle($value = 'I am a subtitle!');
 
-        $this->assertSame($value, $element->toArray()['activitySubtitle']);
+        $this->assertSame($value, $field->toArray()['activitySubtitle']);
     }
 
     public function testText()
     {
-        $element = (new ActivityField())
+        $field = (new ActivityField())
             ->text($value = 'Text goes here');
 
-        $this->assertSame($value, $element->toArray()['activityText']);
+        $this->assertSame($value, $field->toArray()['activityText']);
     }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Tests/Section/FactFieldTest.php b/src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Tests/Section/FactFieldTest.php
@@ -10,17 +10,17 @@ final class FactFieldTest extends TestCase
 {
     public function testName()
     {
-        $element = (new FactField())
+        $field = (new FactField())
             ->name($value = 'Current version');
 
-        $this->assertSame($value, $element->toArray()['name']);
+        $this->assertSame($value, $field->toArray()['name']);
     }
 
     public function testTitle()
     {
-        $element = (new FactField())
+        $field = (new FactField())
             ->value($value = '5.3');
 
-        $this->assertSame($value, $element->toArray()['value']);
+        $this->assertSame($value, $field->toArray()['value']);
     }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Tests/Section/ImageFieldTest.php b/src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Tests/Section/ImageFieldTest.php
@@ -9,17 +9,17 @@ final class ImageFieldTest extends TestCase
 {
     public function testImage()
     {
-        $element = (new ImageField())
+        $field = (new ImageField())
             ->image($value = 'https://symfony.com/logo.png');
 
-        $this->assertSame($value, $element->toArray()['image']);
+        $this->assertSame($value, $field->toArray()['image']);
     }
 
     public function testTitle()
     {
-        $element = (new ImageField())
+        $field = (new ImageField())
             ->title($value = 'Symfony is great!');
 
-        $this->assertSame($value, $element->toArray()['title']);
+        $this->assertSame($value, $field->toArray()['title']);
     }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Tests/Section/SectionTest.php b/src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Tests/Section/SectionTest.php
@@ -5,12 +5,9 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Action\ActionCardAction;
 use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Action\ActionInterface;
-use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Action\DateInput;
 use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Action\HttpPostAction;
 use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Action\InvokeAddInCommandAction;
-use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Action\MultiChoiceInput;
 use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Action\OpenUriAction;
-use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Action\TextInput;
 use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Section\ActivityField;
 use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Section\FactField;
 use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Section\ImageField;
@@ -78,12 +75,12 @@ public function testActivity()
 
     public function testImage()
     {
-        $element = (new ImageField())
+        $image = (new ImageField())
             ->image($imageUrl = 'https://symfony.com/logo.png')
             ->title($title = 'Symfony logo');
 
         $section = (new Section())
-            ->image($element);
+            ->image($image);
 
         $this->assertCount(1, $section->toArray()['images']);
         $this->assertSame(
@@ -96,12 +93,12 @@ public function testImage()
 
     public function testFact()
     {
-        $element = (new FactField())
+        $fact = (new FactField())
             ->name($name = 'Current version')
             ->value($value = '5.3');
 
         $section = (new Section())
-            ->fact($element);
+            ->fact($fact);
 
         $this->assertCount(1, $section->toArray()['facts']);
         $this->assertSame(

Original file line number	Diff line number	Diff line change
`@@ -9,33 +9,33 @@ final class ActivityFieldTest extends TestCase`
`9`	`9`	`{`
`10`	`10`	`public function testImage()`
`11`	`11`	`{`
`12`		`- $element = (new ActivityField())`
	`12`	`+ $field = (new ActivityField())`
`13`	`13`	`->image($value = 'https://symfony.com/logo.png');`
`14`	`14`
`15`		`- $this->assertSame($value, $element->toArray()['activityImage']);`
	`15`	`+ $this->assertSame($value, $field->toArray()['activityImage']);`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`public function testTitle()`
`19`	`19`	`{`
`20`		`- $element = (new ActivityField())`
	`20`	`+ $field = (new ActivityField())`
`21`	`21`	`->title($value = 'Symfony is great!');`
`22`	`22`
`23`		`- $this->assertSame($value, $element->toArray()['activityTitle']);`
	`23`	`+ $this->assertSame($value, $field->toArray()['activityTitle']);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`public function testSubtitle()`
`27`	`27`	`{`
`28`		`- $element = (new ActivityField())`
	`28`	`+ $field = (new ActivityField())`
`29`	`29`	`->subtitle($value = 'I am a subtitle!');`
`30`	`30`
`31`		`- $this->assertSame($value, $element->toArray()['activitySubtitle']);`
	`31`	`+ $this->assertSame($value, $field->toArray()['activitySubtitle']);`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`public function testText()`
`35`	`35`	`{`
`36`		`- $element = (new ActivityField())`
	`36`	`+ $field = (new ActivityField())`
`37`	`37`	`->text($value = 'Text goes here');`
`38`	`38`
`39`		`- $this->assertSame($value, $element->toArray()['activityText']);`
	`39`	`+ $this->assertSame($value, $field->toArray()['activityText']);`
`40`	`40`	`}`
`41`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,17 +10,17 @@ final class FactFieldTest extends TestCase`
`10`	`10`	`{`
`11`	`11`	`public function testName()`
`12`	`12`	`{`
`13`		`- $element = (new FactField())`
	`13`	`+ $field = (new FactField())`
`14`	`14`	`->name($value = 'Current version');`
`15`	`15`
`16`		`- $this->assertSame($value, $element->toArray()['name']);`
	`16`	`+ $this->assertSame($value, $field->toArray()['name']);`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`public function testTitle()`
`20`	`20`	`{`
`21`		`- $element = (new FactField())`
	`21`	`+ $field = (new FactField())`
`22`	`22`	`->value($value = '5.3');`
`23`	`23`
`24`		`- $this->assertSame($value, $element->toArray()['value']);`
	`24`	`+ $this->assertSame($value, $field->toArray()['value']);`
`25`	`25`	`}`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,17 +9,17 @@ final class ImageFieldTest extends TestCase`
`9`	`9`	`{`
`10`	`10`	`public function testImage()`
`11`	`11`	`{`
`12`		`- $element = (new ImageField())`
	`12`	`+ $field = (new ImageField())`
`13`	`13`	`->image($value = 'https://symfony.com/logo.png');`
`14`	`14`
`15`		`- $this->assertSame($value, $element->toArray()['image']);`
	`15`	`+ $this->assertSame($value, $field->toArray()['image']);`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`public function testTitle()`
`19`	`19`	`{`
`20`		`- $element = (new ImageField())`
	`20`	`+ $field = (new ImageField())`
`21`	`21`	`->title($value = 'Symfony is great!');`
`22`	`22`
`23`		`- $this->assertSame($value, $element->toArray()['title']);`
	`23`	`+ $this->assertSame($value, $field->toArray()['title']);`
`24`	`24`	`}`
`25`	`25`	`}`