bug #40850 [FrameworkBundle][Notifier] Fix wrong class name usage (jschaedl)

fabpot · fabpot · commit d8e4af200912 · 2021-04-18T07:31:00.000+02:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [FrameworkBundle][Notifier] Fix wrong class name usage | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | -  | License | MIT | Doc PR | -  I got the following error message a new symfony installation while trying to require fake-sms and fake-chat: ``` symfony new --version=next --dir=new cd new composer req notifier composer req symfony/fake-chat-notifier ``` ``` Executing script cache:clear [KO] [KO] Script cache:clear returned with error code 1 !! !! In ContainerBuilder.php line 994: !! !! You have requested a non-existent service "notifier.transport_factory.fakechat". !! !! !! Script `@auto`-scripts was called via post-update-cmd Installation failed, reverting ./composer.json and ./composer.lock to their original content. ``` Commits ------- 213ef7f Fix wrong class name usage
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -2436,12 +2436,12 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
             $container->removeDefinition($classToServices[MercureTransportFactory::class]);
         }
 
-        if (ContainerBuilder::willBeAvailable('symfony/fake-chat-notifier', FakeSmsTransportFactory::class, ['symfony/framework-bundle']) && ContainerBuilder::willBeAvailable('symfony/fake-chat-notifier', FakeSmsTransportFactory::class, ['symfony/notifier']) && ContainerBuilder::willBeAvailable('symfony/fake-chat-notifier', FakeSmsTransportFactory::class, ['symfony/mailer'])) {
+        if (ContainerBuilder::willBeAvailable('symfony/fake-chat-notifier', FakeChatTransportFactory::class, ['symfony/framework-bundle', 'symfony/notifier', 'symfony/mailer'])) {
             $container->getDefinition($classToServices[FakeChatTransportFactory::class])
                 ->replaceArgument('$mailer', new Reference('mailer'));
         }
 
-        if (ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/framework-bundle']) && ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/notifier']) && ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/mailer'])) {
+        if (ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/framework-bundle', 'symfony/notifier', 'symfony/mailer'])) {
             $container->getDefinition($classToServices[FakeSmsTransportFactory::class])
                 ->replaceArgument('$mailer', new Reference('mailer'));
         }

Original file line number	Diff line number	Diff line change
`@@ -2436,12 +2436,12 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $`
`2436`	`2436`	`$container->removeDefinition($classToServices[MercureTransportFactory::class]);`
`2437`	`2437`	`}`
`2438`	`2438`
`2439`		`- if (ContainerBuilder::willBeAvailable('symfony/fake-chat-notifier', FakeSmsTransportFactory::class, ['symfony/framework-bundle']) && ContainerBuilder::willBeAvailable('symfony/fake-chat-notifier', FakeSmsTransportFactory::class, ['symfony/notifier']) && ContainerBuilder::willBeAvailable('symfony/fake-chat-notifier', FakeSmsTransportFactory::class, ['symfony/mailer'])) {`
	`2439`	`+ if (ContainerBuilder::willBeAvailable('symfony/fake-chat-notifier', FakeChatTransportFactory::class, ['symfony/framework-bundle', 'symfony/notifier', 'symfony/mailer'])) {`
`2440`	`2440`	`$container->getDefinition($classToServices[FakeChatTransportFactory::class])`
`2441`	`2441`	`->replaceArgument('$mailer', new Reference('mailer'));`
`2442`	`2442`	`}`
`2443`	`2443`
`2444`		`- if (ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/framework-bundle']) && ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/notifier']) && ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/mailer'])) {`
	`2444`	`+ if (ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/framework-bundle', 'symfony/notifier', 'symfony/mailer'])) {`
`2445`	`2445`	`$container->getDefinition($classToServices[FakeSmsTransportFactory::class])`
`2446`	`2446`	`->replaceArgument('$mailer', new Reference('mailer'));`
`2447`	`2447`	`}`