minor #53882 [ExpressionLanguage][Validator] document deprecation and fix test (xabbuh)

nicolas-grekas · nicolas-grekas · commit d995693bb816 · 2024-02-09T15:11:37.000+01:00
This PR was merged into the 7.1 branch. Discussion ---------- [ExpressionLanguage][Validator] document deprecation and fix test | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- e248c61 document deprecation and fix test
diff --git a/UPGRADE-7.1.md b/UPGRADE-7.1.md
@@ -6,6 +6,12 @@ Cache
 
  * Deprecate `CouchbaseBucketAdapter`, use `CouchbaseCollectionAdapter` instead
 
+ExpressionLanguage
+------------------
+
+ * Deprecate passing `null` as the allowed variable names to `ExpressionLanguage::lint()` and `Parser::lint()`,
+   pass the `IGNORE_UNKNOWN_VARIABLES` flag instead to ignore unknown variables during linting
+
 FrameworkBundle
 ---------------
 
diff --git a/src/Symfony/Component/ExpressionLanguage/CHANGELOG.md b/src/Symfony/Component/ExpressionLanguage/CHANGELOG.md
@@ -7,6 +7,8 @@ CHANGELOG
  * Add support for PHP `min` and `max` functions
  * Add `Parser::IGNORE_UNKNOWN_VARIABLES` and `Parser::IGNORE_UNKNOWN_FUNCTIONS` flags to control whether
    parsing and linting should check for unknown variables and functions.
+ * Deprecate passing `null` as the allowed variable names to `ExpressionLanguage::lint()` and `Parser::lint()`,
+   pass the `IGNORE_UNKNOWN_VARIABLES` flag instead to ignore unknown variables during linting
 
 7.0
 ---
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/ExpressionSyntaxValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/ExpressionSyntaxValidatorTest.php
@@ -62,7 +62,7 @@ public function testExpressionWithoutNames()
     {
         $this->validator->validate('1 + 1', new ExpressionSyntax([
             'message' => 'myMessage',
-        ]));
+        ], null, null, []));
 
         $this->assertNoViolation();
     }

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function testExpressionWithoutNames()`
`62`	`62`	`{`
`63`	`63`	`$this->validator->validate('1 + 1', new ExpressionSyntax([`
`64`	`64`	`'message' => 'myMessage',`
`65`		`- ]));`
	`65`	`+ ], null, null, []));`
`66`	`66`
`67`	`67`	`$this->assertNoViolation();`
`68`	`68`	`}`