[Runtime][ErrorHandler] Don't mess with ini_set('assert.warning')

nicolas-grekas · nicolas-grekas · commit db8b86b0ec7a · 2023-07-16T18:41:39.000+02:00
diff --git a/src/Symfony/Component/ErrorHandler/Debug.php b/src/Symfony/Component/ErrorHandler/Debug.php
@@ -31,7 +31,6 @@ public static function enable(): ErrorHandler
 
         @ini_set('zend.assertions', 1);
         ini_set('assert.active', 1);
-        ini_set('assert.warning', 0);
         ini_set('assert.exception', 1);
 
         DebugClassLoader::enable();
diff --git a/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php b/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php
@@ -665,7 +665,7 @@ public function testAssertQuietEval()
             $this->markTestSkipped('zend.assertions is forcibly disabled');
         }
 
-        $ini = [
+        $ini = @[
             ini_set('zend.assertions', 1),
             ini_set('assert.active', 1),
             ini_set('assert.bail', 0),
diff --git a/src/Symfony/Component/Runtime/Internal/BasicErrorHandler.php b/src/Symfony/Component/Runtime/Internal/BasicErrorHandler.php
@@ -32,7 +32,6 @@ public static function register(bool $debug): void
         if (0 <= \ini_get('zend.assertions')) {
             ini_set('zend.assertions', 1);
             ini_set('assert.active', $debug);
-            ini_set('assert.warning', 0);
             ini_set('assert.exception', 1);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -665,7 +665,7 @@ public function testAssertQuietEval()`
`665`	`665`	`$this->markTestSkipped('zend.assertions is forcibly disabled');`
`666`	`666`	`}`
`667`	`667`
`668`		`- $ini = [`
	`668`	`+ $ini = @[`
`669`	`669`	`ini_set('zend.assertions', 1),`
`670`	`670`	`ini_set('assert.active', 1),`
`671`	`671`	`ini_set('assert.bail', 0),`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@ public static function register(bool $debug): void`
`32`	`32`	`if (0 <= \ini_get('zend.assertions')) {`
`33`	`33`	`ini_set('zend.assertions', 1);`
`34`	`34`	`ini_set('assert.active', $debug);`
`35`		`- ini_set('assert.warning', 0);`
`36`	`35`	`ini_set('assert.exception', 1);`
`37`	`36`	`}`
`38`	`37`