Deprecate null/empty string for secret argument

Spomky · Spomky · commit dbf4759212db · 2023-08-20T15:17:39.000+02:00
diff --git a/src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php b/src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php
@@ -32,6 +32,9 @@ final class DefaultLoginRateLimiter extends AbstractRequestRateLimiter
 
     public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactory $localFactory, #[\SensitiveParameter] string $secret = null)
     {
+        if (!$secret) {
+            trigger_deprecation('symfony/security-http', '6.4', 'Calling "%s()" with an empty secret is deprecated, pass a non-empty string instead.', __METHOD__);
+        }
         $this->globalFactory = $globalFactory;
         $this->localFactory = $localFactory;
         $this->secret = $secret;

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,9 @@ final class DefaultLoginRateLimiter extends AbstractRequestRateLimiter`
`32`	`32`
`33`	`33`	`public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactory $localFactory, #[\SensitiveParameter] string $secret = null)`
`34`	`34`	`{`
	`35`	`+ if (!$secret) {`
	`36`	`+ trigger_deprecation('symfony/security-http', '6.4', 'Calling "%s()" with an empty secret is deprecated, pass a non-empty string instead.', __METHOD__);`
	`37`	`+ }`
`35`	`38`	`$this->globalFactory = $globalFactory;`
`36`	`39`	`$this->localFactory = $localFactory;`
`37`	`40`	`$this->secret = $secret;`