fix(property-info): make sure that SerializerExtractor returns null for invalid class metadata

wuchen90 · wuchen90 · commit df8f3b13c789 · 2025-01-06T12:22:43.000+01:00
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/SerializerExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/SerializerExtractor.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\PropertyInfo\Extractor;
 
 use Symfony\Component\PropertyInfo\PropertyListExtractorInterface;
+use Symfony\Component\Serializer\Exception\InvalidArgumentException;
 use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactoryInterface;
 
 /**
@@ -34,12 +35,13 @@ public function getProperties(string $class, array $context = []): ?array
             return null;
         }
 
-        if (!$this->classMetadataFactory->getMetadataFor($class)) {
+        try {
+            $serializerClassMetadata = $this->classMetadataFactory->getMetadataFor($class);
+        } catch (InvalidArgumentException) {
             return null;
         }
 
         $properties = [];
-        $serializerClassMetadata = $this->classMetadataFactory->getMetadataFor($class);
 
         foreach ($serializerClassMetadata->getAttributesMetadata() as $serializerAttributeMetadata) {
             if (!$serializerAttributeMetadata->isIgnored() && (null === $context['serializer_groups'] || array_intersect($context['serializer_groups'], $serializerAttributeMetadata->getGroups()))) {
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/SerializerExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/SerializerExtractorTest.php
@@ -55,4 +55,9 @@ public function testGetPropertiesWithAnyGroup()
     {
         $this->assertSame(['analyses', 'feet'], $this->extractor->getProperties(AdderRemoverDummy::class, ['serializer_groups' => null]));
     }
+
+    public function testGetPropertiesWithNonExistentClassReturnsNull()
+    {
+        $this->assertSame(null, $this->extractor->getProperties('NonExistent'));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -55,4 +55,9 @@ public function testGetPropertiesWithAnyGroup()`
`55`	`55`	`{`
`56`	`56`	`$this->assertSame(['analyses', 'feet'], $this->extractor->getProperties(AdderRemoverDummy::class, ['serializer_groups' => null]));`
`57`	`57`	`}`
	`58`	`+`
	`59`	`+ public function testGetPropertiesWithNonExistentClassReturnsNull()`
	`60`	`+ {`
	`61`	`+ $this->assertSame(null, $this->extractor->getProperties('NonExistent'));`
	`62`	`+ }`
`58`	`63`	`}`