feature #39557 [Notifier] [BC BREAK] Final classes (OskarStark)

chalasr · chalasr · commit e1e1defffa29 · 2020-12-30T23:13:32.000+01:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] [BC BREAK] Final classes | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no, BC BREAK, but experimental  | Deprecations? | no  | Tickets | --- | License | MIT | Doc PR | --- Commits ------- 733ba61 [Notifier] [BC BREAK] Final classes
diff --git a/src/Symfony/Component/Notifier/Bridge/LinkedIn/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/LinkedIn/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * The bridge is not marked as `@experimental` anymore
+* [BC BREAK] `LinkedInTransportFactory` is now final
 
 5.2.0
 -----
diff --git a/src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInTransportFactory.php b/src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInTransportFactory.php
@@ -19,7 +19,7 @@
 /**
  * @author Smaïne Milianni <smaine.milianni@gmail.com>
  */
-class LinkedInTransportFactory extends AbstractTransportFactory
+final class LinkedInTransportFactory extends AbstractTransportFactory
 {
     public function create(Dsn $dsn): TransportInterface
     {
diff --git a/src/Symfony/Component/Notifier/Bridge/Smsapi/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/Smsapi/CHANGELOG.md
@@ -0,0 +1,7 @@
+CHANGELOG
+=========
+
+5.3.0
+-----
+
+ * Added the bridge
diff --git a/src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransport.php b/src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransport.php
@@ -22,6 +22,8 @@
 
 /**
  * @author Marcin Szepczynski <szepczynski@gmail.com>
+ *
+ * @experimental in 5.3
  */
 final class SmsapiTransport extends AbstractTransport
 {
diff --git a/src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransportFactory.php b/src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransportFactory.php
@@ -19,8 +19,10 @@
 
 /**
  * @author Marcin Szepczynski <szepczynski@gmail.com>
+ *
+ * @experimental in 5.3
  */
-class SmsapiTransportFactory extends AbstractTransportFactory
+final class SmsapiTransportFactory extends AbstractTransportFactory
 {
     /**
      * @return SmsapiTransport
diff --git a/src/Symfony/Component/Notifier/Bridge/Zulip/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/Zulip/CHANGELOG.md
@@ -5,6 +5,8 @@ CHANGELOG
 -----
 
  * The bridge is not marked as `@experimental` anymore
+* [BC BREAK] `ZulipTransport` is now final
+* [BC BREAK] `ZulipTransportFactory` is now final
 
 5.2.0
 -----
diff --git a/src/Symfony/Component/Notifier/Bridge/Zulip/ZulipTransport.php b/src/Symfony/Component/Notifier/Bridge/Zulip/ZulipTransport.php
@@ -24,7 +24,7 @@
 /**
  * @author Mohammad Emran Hasan <phpfour@gmail.com>
  */
-class ZulipTransport extends AbstractTransport
+final class ZulipTransport extends AbstractTransport
 {
     private $email;
     private $token;
diff --git a/src/Symfony/Component/Notifier/Bridge/Zulip/ZulipTransportFactory.php b/src/Symfony/Component/Notifier/Bridge/Zulip/ZulipTransportFactory.php
@@ -20,7 +20,7 @@
 /**
  * @author Mohammad Emran Hasan <phpfour@gmail.com>
  */
-class ZulipTransportFactory extends AbstractTransportFactory
+final class ZulipTransportFactory extends AbstractTransportFactory
 {
     /**
      * @return ZulipTransport

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`/**`
`20`	`20`	`* @author Smaïne Milianni <smaine.milianni@gmail.com>`
`21`	`21`	`*/`
`22`		`-class LinkedInTransportFactory extends AbstractTransportFactory`
	`22`	`+final class LinkedInTransportFactory extends AbstractTransportFactory`
`23`	`23`	`{`
`24`	`24`	`public function create(Dsn $dsn): TransportInterface`
`25`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@`
`22`	`22`
`23`	`23`	`/**`
`24`	`24`	`* @author Marcin Szepczynski <szepczynski@gmail.com>`
	`25`	`+ *`
	`26`	`+ * @experimental in 5.3`
`25`	`27`	`*/`
`26`	`28`	`final class SmsapiTransport extends AbstractTransport`
`27`	`29`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`	`/**`
`25`	`25`	`* @author Mohammad Emran Hasan <phpfour@gmail.com>`
`26`	`26`	`*/`
`27`		`-class ZulipTransport extends AbstractTransport`
	`27`	`+final class ZulipTransport extends AbstractTransport`
`28`	`28`	`{`
`29`	`29`	`private $email;`
`30`	`30`	`private $token;`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`/**`
`21`	`21`	`* @author Mohammad Emran Hasan <phpfour@gmail.com>`
`22`	`22`	`*/`
`23`		`-class ZulipTransportFactory extends AbstractTransportFactory`
	`23`	`+final class ZulipTransportFactory extends AbstractTransportFactory`
`24`	`24`	`{`
`25`	`25`	`/**`
`26`	`26`	`* @return ZulipTransport`