Update doc

andrerom · andrerom · commit e264119ac3ae · 2019-09-22T20:38:16.000+02:00
[skip ci]
diff --git a/src/Symfony/Component/Cache/Adapter/RedisTagAwareAdapter.php b/src/Symfony/Component/Cache/Adapter/RedisTagAwareAdapter.php
@@ -18,21 +18,21 @@
 use Symfony\Component\Cache\Traits\RedisTrait;
 
 /**
- * Stores tag id <> cache id relationship as a Redis Set, lookup on invalidation using sPOP.
+ * Stores tag id <> cache id relationship as a Redis Set, lookup on invalidation using RENAME+SMEMBERS.
  *
  * Set (tag relation info) is stored without expiry (non-volatile), while cache always gets an expiry (volatile) even
  * if not set by caller. Thus if you configure redis with the right eviction policy you can be safe this tag <> cache
  * relationship survives eviction (cache cleanup when Redis runs out of memory).
  *
  * Requirements:
  *  - Client: PHP Redis or Predis
- *            Due to lack of RENAME support it is not recommended to use PredisCluster, instead use RedisCluster.
+ *            Note: Due to lack of RENAME support it is not recommended to use Cluster on Predis, instead use phpredis.
  *  - Server: Redis 2.8+
  *            Configured with any `volatile-*` eviction policy, OR `noeviction` if it will NEVER fill up memory
  *
  * Design limitations:
  *  - Max 4 billion cache keys per cache tag as limited by Redis Set datatype.
- *    E.g. If you use a "all" items tag for expiry instead of clear(), that limits you to 4 billion cache items as well.
+ *    E.g. If you use a "all" items tag for expiry instead of clear(), that limits you to 4 billion cache items also.
  *
  * @see https://redis.io/topics/lru-cache#eviction-policies Documentation for Redis eviction policies.
  * @see https://redis.io/topics/data-types#sets Documentation for Redis Set datatype.

Original file line number	Diff line number	Diff line change
`@@ -18,21 +18,21 @@`
`18`	`18`	`use Symfony\Component\Cache\Traits\RedisTrait;`
`19`	`19`
`20`	`20`	`/**`
`21`		`- * Stores tag id <> cache id relationship as a Redis Set, lookup on invalidation using sPOP.`
	`21`	`+ * Stores tag id <> cache id relationship as a Redis Set, lookup on invalidation using RENAME+SMEMBERS.`
`22`	`22`	`*`
`23`	`23`	`* Set (tag relation info) is stored without expiry (non-volatile), while cache always gets an expiry (volatile) even`
`24`	`24`	`* if not set by caller. Thus if you configure redis with the right eviction policy you can be safe this tag <> cache`
`25`	`25`	`* relationship survives eviction (cache cleanup when Redis runs out of memory).`
`26`	`26`	`*`
`27`	`27`	`* Requirements:`
`28`	`28`	`* - Client: PHP Redis or Predis`
`29`		`- * Due to lack of RENAME support it is not recommended to use PredisCluster, instead use RedisCluster.`
	`29`	`+ * Note: Due to lack of RENAME support it is not recommended to use Cluster on Predis, instead use phpredis.`
`30`	`30`	`* - Server: Redis 2.8+`
`31`	`31`	* Configured with any `volatile-*` eviction policy, OR `noeviction` if it will NEVER fill up memory
`32`	`32`	`*`
`33`	`33`	`* Design limitations:`
`34`	`34`	`* - Max 4 billion cache keys per cache tag as limited by Redis Set datatype.`
`35`		`- * E.g. If you use a "all" items tag for expiry instead of clear(), that limits you to 4 billion cache items as well.`
	`35`	`+ * E.g. If you use a "all" items tag for expiry instead of clear(), that limits you to 4 billion cache items also.`
`36`	`36`	`*`
`37`	`37`	`* @see https://redis.io/topics/lru-cache#eviction-policies Documentation for Redis eviction policies.`
`38`	`38`	`* @see https://redis.io/topics/data-types#sets Documentation for Redis Set datatype.`