feature #33317 [Messenger] Added support for from_transport attribute on messenger.message_handler tag (ruudk)

fabpot · fabpot · commit e2e73eff1db6 · 2019-09-25T20:39:14.000+02:00
This PR was squashed before being merged into the 4.4 branch (closes #33317). Discussion ---------- [Messenger] Added support for `from_transport` attribute on `messenger.message_handler` tag | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33306 | License | MIT | Doc PR | symfony/symfony-docs#12231 Right now, it's only possible to have dynamic `from_transport` when using `MessageSubscriberInterface`. Things like `priority` and `bus` can already be added as attributes on the messenger.message_handler` tag. With this PR it now also supports `from_transport`. Commits ------- c965e4e [Messenger] Added support for `from_transport` attribute on `messenger.message_handler` tag
diff --git a/src/Symfony/Component/Messenger/CHANGELOG.md b/src/Symfony/Component/Messenger/CHANGELOG.md
@@ -9,6 +9,7 @@ CHANGELOG
  * Added support for auto trimming of Redis streams.
  * `InMemoryTransport` handle acknowledged and rejected messages.
  * Made all dispatched worker event classes final.
+ * Added support for `from_transport` attribute on `messenger.message_handler` tag.
 
 4.3.0
 -----
diff --git a/src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php b/src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php
@@ -109,6 +109,10 @@ private function registerHandlers(ContainerBuilder $container, array $busIds)
                         $options = ['method' => $options];
                     }
 
+                    if (!isset($options['from_transport']) && isset($tag['from_transport'])) {
+                        $options['from_transport'] = $tag['from_transport'];
+                    }
+
                     $priority = $tag['priority'] ?? $options['priority'] ?? 0;
                     $method = $options['method'] ?? '__invoke';
 
diff --git a/src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php b/src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php
@@ -78,6 +78,25 @@ public function testProcess()
         );
     }
 
+    public function testFromTransportViaTagAttribute()
+    {
+        $container = $this->getContainerBuilder($busId = 'message_bus');
+        $container
+            ->register(DummyHandler::class, DummyHandler::class)
+            ->addTag('messenger.message_handler', ['from_transport' => 'async'])
+        ;
+
+        (new MessengerPass())->process($container);
+
+        $handlersLocatorDefinition = $container->getDefinition($busId.'.messenger.handlers_locator');
+        $this->assertSame(HandlersLocator::class, $handlersLocatorDefinition->getClass());
+
+        $handlerDescriptionMapping = $handlersLocatorDefinition->getArgument(0);
+        $this->assertCount(1, $handlerDescriptionMapping);
+
+        $this->assertHandlerDescriptor($container, $handlerDescriptionMapping, DummyMessage::class, [DummyHandler::class], [['from_transport' => 'async']]);
+    }
+
     public function testProcessHandlersByBus()
     {
         $container = $this->getContainerBuilder($commandBusId = 'command_bus');

Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,10 @@ private function registerHandlers(ContainerBuilder $container, array $busIds)`
`109`	`109`	`$options = ['method' => $options];`
`110`	`110`	`}`
`111`	`111`
	`112`	`+ if (!isset($options['from_transport']) && isset($tag['from_transport'])) {`
	`113`	`+ $options['from_transport'] = $tag['from_transport'];`
	`114`	`+ }`
	`115`	`+`
`112`	`116`	`$priority = $tag['priority'] ?? $options['priority'] ?? 0;`
`113`	`117`	`$method = $options['method'] ?? '__invoke';`
`114`	`118`