Skip to content

Commit e3f09df

Browse files
fabpotfabpot
committed
Merge branch '2.7' into 2.8
* 2.7: removed @Covers annotations in tests removed all @Covers annotations [PropertyAccess] Major performance improvement
2 parents 64917c7 + d3008b4 commit e3f09df

38 files changed

+2
-591
lines changed

‎src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/ContainerBuilderTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@
2424
*/
2525
class ContainerBuilderTest extends \PHPUnit_Framework_TestCase
2626
{
27-
/**
28-
* @covers Symfony\Component\DependencyInjection\ContainerBuilder::createService
29-
*/
3027
public function testCreateProxyServiceWithRuntimeInstantiator()
3128
{
3229
$builder = new ContainerBuilder();

‎src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/Instantiator/RuntimeInstantiatorTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
* Tests for {@see \Symfony\Bridge\ProxyManager\LazyProxy\Instantiator\RuntimeInstantiator}.
1919
*
2020
* @author Marco Pivetta <ocramius@gmail.com>
21-
*
22-
* @covers \Symfony\Bridge\ProxyManager\LazyProxy\Instantiator\RuntimeInstantiator
2321
*/
2422
class RuntimeInstantiatorTest extends \PHPUnit_Framework_TestCase
2523
{

‎src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/ProxyDumperTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
* Tests for {@see \Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper}.
1919
*
2020
* @author Marco Pivetta <ocramius@gmail.com>
21-
*
22-
* @covers \Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper
2321
*/
2422
class ProxyDumperTest extends \PHPUnit_Framework_TestCase
2523
{

‎src/Symfony/Bridge/Twig/Tests/Command/LintCommandTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
use Symfony\Component\Console\Output\OutputInterface;
1717
use Symfony\Component\Console\Tester\CommandTester;
1818

19-
/**
20-
* @covers \Symfony\Bridge\Twig\Command\LintCommand
21-
*/
2219
class LintCommandTest extends \PHPUnit_Framework_TestCase
2320
{
2421
private $files;

‎src/Symfony/Component/BrowserKit/Tests/ClientTest.php

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -73,27 +73,18 @@ protected function getScript($request)
7373

7474
class ClientTest extends \PHPUnit_Framework_TestCase
7575
{
76-
/**
77-
* @covers Symfony\Component\BrowserKit\Client::getHistory
78-
*/
7976
public function testGetHistory()
8077
{
8178
$client = new TestClient(array(), $history = new History());
8279
$this->assertSame($history, $client->getHistory(), '->getHistory() returns the History');
8380
}
8481

85-
/**
86-
* @covers Symfony\Component\BrowserKit\Client::getCookieJar
87-
*/
8882
public function testGetCookieJar()
8983
{
9084
$client = new TestClient(array(), null, $cookieJar = new CookieJar());
9185
$this->assertSame($cookieJar, $client->getCookieJar(), '->getCookieJar() returns the CookieJar');
9286
}
9387

94-
/**
95-
* @covers Symfony\Component\BrowserKit\Client::getRequest
96-
*/
9788
public function testGetRequest()
9889
{
9990
$client = new TestClient();
@@ -140,9 +131,6 @@ public function testGetContent()
140131
$this->assertEquals($json, $client->getRequest()->getContent());
141132
}
142133

143-
/**
144-
* @covers Symfony\Component\BrowserKit\Client::getCrawler
145-
*/
146134
public function testGetCrawler()
147135
{
148136
$client = new TestClient();

‎src/Symfony/Component/Config/Tests/Loader/DelegatingLoaderTest.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,12 @@
1616

1717
class DelegatingLoaderTest extends \PHPUnit_Framework_TestCase
1818
{
19-
/**
20-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::__construct
21-
*/
2219
public function testConstructor()
2320
{
2421
$loader = new DelegatingLoader($resolver = new LoaderResolver());
2522
$this->assertTrue(true, '__construct() takes a loader resolver as its first argument');
2623
}
2724

28-
/**
29-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::getResolver
30-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::setResolver
31-
*/
3225
public function testGetSetResolver()
3326
{
3427
$resolver = new LoaderResolver();
@@ -38,9 +31,6 @@ public function testGetSetResolver()
3831
$this->assertSame($resolver, $loader->getResolver(), '->setResolver() sets the resolver loader');
3932
}
4033

41-
/**
42-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::supports
43-
*/
4434
public function testSupports()
4535
{
4636
$loader1 = $this->getMock('Symfony\Component\Config\Loader\LoaderInterface');
@@ -54,9 +44,6 @@ public function testSupports()
5444
$this->assertFalse($loader->supports('foo.foo'), '->supports() returns false if the resource is not loadable');
5545
}
5646

57-
/**
58-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::load
59-
*/
6047
public function testLoad()
6148
{
6249
$loader = $this->getMock('Symfony\Component\Config\Loader\LoaderInterface');

‎src/Symfony/Component/Config/Tests/Loader/FileLoaderTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616

1717
class FileLoaderTest extends \PHPUnit_Framework_TestCase
1818
{
19-
/**
20-
* @covers Symfony\Component\Config\Loader\FileLoader
21-
*/
2219
public function testImportWithFileLocatorDelegation()
2320
{
2421
$locatorMock = $this->getMock('Symfony\Component\Config\FileLocatorInterface');

‎src/Symfony/Component/Config/Tests/Loader/LoaderResolverTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515

1616
class LoaderResolverTest extends \PHPUnit_Framework_TestCase
1717
{
18-
/**
19-
* @covers Symfony\Component\Config\Loader\LoaderResolver::__construct
20-
*/
2118
public function testConstructor()
2219
{
2320
$resolver = new LoaderResolver(array(
@@ -27,9 +24,6 @@ public function testConstructor()
2724
$this->assertEquals(array($loader), $resolver->getLoaders(), '__construct() takes an array of loaders as its first argument');
2825
}
2926

30-
/**
31-
* @covers Symfony\Component\Config\Loader\LoaderResolver::resolve
32-
*/
3327
public function testResolve()
3428
{
3529
$loader = $this->getMock('Symfony\Component\Config\Loader\LoaderInterface');
@@ -42,10 +36,6 @@ public function testResolve()
4236
$this->assertEquals($loader, $resolver->resolve(function () {}), '->resolve() returns the loader for the given resource');
4337
}
4438

45-
/**
46-
* @covers Symfony\Component\Config\Loader\LoaderResolver::getLoaders
47-
* @covers Symfony\Component\Config\Loader\LoaderResolver::addLoader
48-
*/
4939
public function testLoaders()
5040
{
5141
$resolver = new LoaderResolver();

‎src/Symfony/Component/Console/Tests/Helper/HelperSetTest.php

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616

1717
class HelperSetTest extends \PHPUnit_Framework_TestCase
1818
{
19-
/**
20-
* @covers \Symfony\Component\Console\Helper\HelperSet::__construct
21-
*/
2219
public function testConstructor()
2320
{
2421
$mock_helper = $this->getGenericMockHelper('fake_helper');
@@ -28,9 +25,6 @@ public function testConstructor()
2825
$this->assertTrue($helperset->has('fake_helper_alias'), '__construct sets helper alias for given helper');
2926
}
3027

31-
/**
32-
* @covers \Symfony\Component\Console\Helper\HelperSet::set
33-
*/
3428
public function testSet()
3529
{
3630
$helperset = new HelperSet();
@@ -49,19 +43,13 @@ public function testSet()
4943
$this->assertTrue($helperset->has('fake_helper_alias'), '->set() adds helper alias when set');
5044
}
5145

52-
/**
53-
* @covers \Symfony\Component\Console\Helper\HelperSet::has
54-
*/
5546
public function testHas()
5647
{
5748
$helperset = new HelperSet(array('fake_helper_alias' => $this->getGenericMockHelper('fake_helper')));
5849
$this->assertTrue($helperset->has('fake_helper'), '->has() finds set helper');
5950
$this->assertTrue($helperset->has('fake_helper_alias'), '->has() finds set helper by alias');
6051
}
6152

62-
/**
63-
* @covers \Symfony\Component\Console\Helper\HelperSet::get
64-
*/
6553
public function testGet()
6654
{
6755
$helper_01 = $this->getGenericMockHelper('fake_helper_01');
@@ -83,9 +71,6 @@ public function testGet()
8371
}
8472
}
8573

86-
/**
87-
* @covers \Symfony\Component\Console\Helper\HelperSet::setCommand
88-
*/
8974
public function testSetCommand()
9075
{
9176
$cmd_01 = new Command('foo');
@@ -101,9 +86,6 @@ public function testSetCommand()
10186
$this->assertEquals($cmd_02, $helperset->getCommand(), '->setCommand() overwrites stored command with consecutive calls');
10287
}
10388

104-
/**
105-
* @covers \Symfony\Component\Console\Helper\HelperSet::getCommand
106-
*/
10789
public function testGetCommand()
10890
{
10991
$cmd = new Command('foo');
@@ -112,9 +94,6 @@ public function testGetCommand()
11294
$this->assertEquals($cmd, $helperset->getCommand(), '->getCommand() retrieves stored command');
11395
}
11496

115-
/**
116-
* @covers \Symfony\Component\Console\Helper\HelperSet::getIterator
117-
*/
11897
public function testIteration()
11998
{
12099
$helperset = new HelperSet();

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy