Improve codestyle

tatankat · nicolas-grekas · tatankat · commit e50bc7e5c57d · 2022-09-13T16:24:59.000+02:00
Co-authored-by: Nicolas Grekas &lt;nicolas.grekas@gmail.com&gt;
diff --git a/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php b/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php
@@ -159,12 +159,10 @@ private function connect()
             }
         }
 
-        $connectResult = ldap_connect($this->config['connection_string']);
-
-        if (false === $connectResult) {
-            throw new LdapException('Syntax of the (computed) connection string is bad: '.$this->config['connection_string']);
+        if (false === $connection = ldap_connect($this->config['connection_string'])) {
+            throw new LdapException('Invalid connection string: '.$this->config['connection_string']);
         } else {
-            $this->connection = $connectResult;
+            $this->connection = $connection;
         }
 
         foreach ($this->config['options'] as $name => $value) {

Original file line number	Diff line number	Diff line change
`@@ -159,12 +159,10 @@ private function connect()`
`159`	`159`	`}`
`160`	`160`	`}`
`161`	`161`
`162`		`- $connectResult = ldap_connect($this->config['connection_string']);`
`163`		`-`
`164`		`- if (false === $connectResult) {`
`165`		`- throw new LdapException('Syntax of the (computed) connection string is bad: '.$this->config['connection_string']);`
	`162`	`+ if (false === $connection = ldap_connect($this->config['connection_string'])) {`
	`163`	`+ throw new LdapException('Invalid connection string: '.$this->config['connection_string']);`
`166`	`164`	`} else {`
`167`		`- $this->connection = $connectResult;`
	`165`	`+ $this->connection = $connection;`
`168`	`166`	`}`
`169`	`167`
`170`	`168`	`foreach ($this->config['options'] as $name => $value) {`