bug #16870 [FrameworkBundle] Disable the server:run command when Process component is missing (gnugat, xabbuh)

fabpot · fabpot · commit e5dda019ae22 · 2015-12-07T22:51:02.000+01:00
This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] Disable the server:run command when Process component is missing | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This also backports the improvement for the `suggest` section from #16650 to the `2.3` branch. Commits ------- 99d1741 disable server:run cmd without Process component 604174c Suggested Process dependency
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php
@@ -34,6 +34,10 @@ public function isEnabled()
             return false;
         }
 
+        if (!class_exists('Symfony\Component\Process\Process')) {
+            return false;
+        }
+
         return parent::isEnabled();
     }
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/composer.json b/src/Symfony/Bundle/FrameworkBundle/composer.json
@@ -48,7 +48,8 @@
         "symfony/finder": "For using the translation loader and cache warmer",
         "symfony/form": "For using forms",
         "symfony/validator": "For using validation",
-        "symfony/serializer": "For using the serializer service"
+        "symfony/serializer": "For using the serializer service",
+        "symfony/process": "For using the server:run command"
     },
     "autoload": {
         "psr-0": { "Symfony\\Bundle\\FrameworkBundle\\": "" },

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,10 @@ public function isEnabled()`
`34`	`34`	`return false;`
`35`	`35`	`}`
`36`	`36`
	`37`	`+ if (!class_exists('Symfony\Component\Process\Process')) {`
	`38`	`+ return false;`
	`39`	`+ }`
	`40`	`+`
`37`	`41`	`return parent::isEnabled();`
`38`	`42`	`}`
`39`	`43`