feature #52730 [Serializer] Consider SerializedPath in debug command output (jschaedl)

fabpot · fabpot · commit e7d73e81f221 · 2023-11-26T18:03:46.000+01:00
This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [Serializer] Consider SerializedPath in debug command output | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT The `debug:serializer` command does not show `SerializedPath` information and I figured it might makes sense to add it. Corresponding symfony-docs pr symfony/symfony-docs#19184 Commits ------- 24cdc43 [Serializer] Consider SerializedPath in debug command output
diff --git a/src/Symfony/Component/Serializer/Command/DebugCommand.php b/src/Symfony/Component/Serializer/Command/DebugCommand.php
@@ -102,6 +102,7 @@ private function getAttributesData(ClassMetadataInterface $classMetadata): array
                 'groups' => $attributeMetadata->getGroups(),
                 'maxDepth' => $attributeMetadata->getMaxDepth(),
                 'serializedName' => $attributeMetadata->getSerializedName(),
+                'serializedPath' => $attributeMetadata->getSerializedPath() ? (string) $attributeMetadata->getSerializedPath() : null,
                 'ignore' => $attributeMetadata->isIgnored(),
                 'normalizationContexts' => $attributeMetadata->getNormalizationContexts(),
                 'denormalizationContexts' => $attributeMetadata->getDenormalizationContexts(),
diff --git a/src/Symfony/Component/Serializer/Tests/Command/DebugCommandTest.php b/src/Symfony/Component/Serializer/Tests/Command/DebugCommandTest.php
@@ -46,6 +46,7 @@ public function testOutputWithClassArgument()
             |          |   ],                                |
             |          |   "maxDepth" => 1,                  |
             |          |   "serializedName" => "identifier", |
+            |          |   "serializedPath" => null,         |
             |          |   "ignore" => true,                 |
             |          |   "normalizationContexts" => [      |
             |          |     "*" => [                        |
@@ -66,6 +67,7 @@ public function testOutputWithClassArgument()
             |          |   "groups" => [],                   |
             |          |   "maxDepth" => null,               |
             |          |   "serializedName" => null,         |
+            |          |   "serializedPath" => [data][name], |
             |          |   "ignore" => false,                |
             |          |   "normalizationContexts" => [],    |
             |          |   "denormalizationContexts" => []   |
diff --git a/src/Symfony/Component/Serializer/Tests/Dummy/DummyClassOne.php b/src/Symfony/Component/Serializer/Tests/Dummy/DummyClassOne.php
@@ -16,6 +16,7 @@
 use Symfony\Component\Serializer\Attribute\Ignore;
 use Symfony\Component\Serializer\Attribute\MaxDepth;
 use Symfony\Component\Serializer\Attribute\SerializedName;
+use Symfony\Component\Serializer\Attribute\SerializedPath;
 
 class DummyClassOne
 {
@@ -29,5 +30,6 @@ class DummyClassOne
     )]
     public string $code;
 
+    #[SerializedPath('[data][name]')]
     public string $name;
 }

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`	`use Symfony\Component\Serializer\Attribute\Ignore;`
`17`	`17`	`use Symfony\Component\Serializer\Attribute\MaxDepth;`
`18`	`18`	`use Symfony\Component\Serializer\Attribute\SerializedName;`
	`19`	`+use Symfony\Component\Serializer\Attribute\SerializedPath;`
`19`	`20`
`20`	`21`	`class DummyClassOne`
`21`	`22`	`{`
`@@ -29,5 +30,6 @@ class DummyClassOne`
`29`	`30`	`)]`
`30`	`31`	`public string $code;`
`31`	`32`
	`33`	`+ #[SerializedPath('[data][name]')]`
`32`	`34`	`public string $name;`
`33`	`35`	`}`