Remove connect $method argument

soyuka · soyuka · commit e9232448c203 · 2020-06-13T18:06:00.000+02:00
diff --git a/src/Symfony/Component/HttpClient/EventSourceHttpClient.php b/src/Symfony/Component/HttpClient/EventSourceHttpClient.php
@@ -37,9 +37,9 @@ public function __construct(HttpClientInterface $client = null, float $reconnect
         $this->reconnectionTime = $reconnectionTime;
     }
 
-    public function connect($method, string $url, array $options = []): ResponseInterface
+    public function connect(string $url, array $options = []): ResponseInterface
     {
-        return $this->request($method, $url, self::mergeDefaultOptions($options, [
+        return $this->request('GET', $url, self::mergeDefaultOptions($options, [
             'buffer' => false,
             'headers' => [
                 'Accept' => 'text/event-stream',
diff --git a/src/Symfony/Component/HttpClient/Tests/EventSourceHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/EventSourceHttpClientTest.php
@@ -78,7 +78,7 @@ public function testGetServerSentEvents()
         $httpClient->method('stream')->willReturn($responseStream);
 
         $es = new EventSourceHttpClient($httpClient);
-        $res = $es->connect('GET', 'http://localhost:8080/events');
+        $res = $es->connect('http://localhost:8080/events');
 
         $expected = [
             new FirstChunk(),

Original file line number	Diff line number	Diff line change
`@@ -37,9 +37,9 @@ public function __construct(HttpClientInterface $client = null, float $reconnect`
`37`	`37`	`$this->reconnectionTime = $reconnectionTime;`
`38`	`38`	`}`
`39`	`39`
`40`		`- public function connect($method, string $url, array $options = []): ResponseInterface`
	`40`	`+ public function connect(string $url, array $options = []): ResponseInterface`
`41`	`41`	`{`
`42`		`- return $this->request($method, $url, self::mergeDefaultOptions($options, [`
	`42`	`+ return $this->request('GET', $url, self::mergeDefaultOptions($options, [`
`43`	`43`	`'buffer' => false,`
`44`	`44`	`'headers' => [`
`45`	`45`	`'Accept' => 'text/event-stream',`