bug #54505 [Serializer] initialize serializer in trait with null (xabbuh)

chalasr · chalasr · commit e928051bcac0 · 2024-04-06T13:50:24.000+02:00
This PR was merged into the 7.0 branch. Discussion ---------- [Serializer] initialize serializer in trait with null | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54417 | License | MIT Commits ------- dae3726 initialize serializer in trait with null
diff --git a/src/Symfony/Component/Serializer/SerializerAwareTrait.php b/src/Symfony/Component/Serializer/SerializerAwareTrait.php
@@ -16,7 +16,7 @@
  */
 trait SerializerAwareTrait
 {
-    protected SerializerInterface $serializer;
+    protected ?SerializerInterface $serializer = null;
 
     public function setSerializer(SerializerInterface $serializer): void
     {
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
@@ -885,6 +885,16 @@ public function testSamePropertyAsMethodWithMethodSerializedName()
 
         $this->assertSame($expected, $this->normalizer->normalize($object));
     }
+
+    public function testNormalizeWithoutSerializerSet()
+    {
+        $normalizer = new ObjectNormalizer(new ClassMetadataFactory(new AttributeLoader()));
+
+        $this->expectException(LogicException::class);
+        $this->expectExceptionMessage('Cannot normalize attribute "foo" because the injected serializer is not a normalizer.');
+
+        $normalizer->normalize(new ObjectConstructorDummy([], [], []));
+    }
 }
 
 class ProxyObjectDummy extends ObjectDummy

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`*/`
`17`	`17`	`trait SerializerAwareTrait`
`18`	`18`	`{`
`19`		`- protected SerializerInterface $serializer;`
	`19`	`+ protected ?SerializerInterface $serializer = null;`
`20`	`20`
`21`	`21`	`public function setSerializer(SerializerInterface $serializer): void`
`22`	`22`	`{`