bug #60564 [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass (cquintana92)

nicolas-grekas · nicolas-grekas · commit ec76ab4f2845 · 2025-06-04T10:41:38.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | None | License | MIT This PR performs the following change: In `KernelTestCase`, the kernel is shut down after every test, as per the `static::ensureKernelShutdown()` call in the `tearDown` function. However, if one was to perform any extra code in their `tearDownAfterClass` and call `getContainer`, it would boot up a new kernel, which would then be left dangling. The main issue with that is that when the next Test class is executed, there would already be a booted kernel, so it could happen that it was pointing to dangling resources. By adding this call to `static::ensureKernelShutdown` in the `tearDownAfterClass`, we can ensure that no dangling kernels are left even after the test class has finished. Commits ------- bf9786c [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass
diff --git a/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php b/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Bundle\FrameworkBundle\Test;
 
+use PHPUnit\Framework\Attributes\AfterClass;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\Container;
 use Symfony\Component\DependencyInjection\ContainerInterface;
@@ -120,8 +121,11 @@ protected static function createKernel(array $options = []): KernelInterface
 
     /**
      * Shuts the kernel down if it was used in the test - called by the tearDown method by default.
+     *
+     * @afterClass
      */
-    protected static function ensureKernelShutdown()
+    #[AfterClass]
+    public static function ensureKernelShutdown()
     {
         if (null !== static::$kernel) {
             static::$kernel->boot();
