bug #60875 [HttpFoundation] Revert " Emit PHP warning when Response::sendHeaders() is called while output has already been sent" (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit ecb09eaf8408 · 2025-06-23T17:17:32.000+02:00
This PR was merged into the 7.3 branch. Discussion ---------- [HttpFoundation] Revert " Emit PHP warning when `Response::sendHeaders()` is called while output has already been sent" | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #60603 | License | MIT This reverts commit cf554e1, reversing changes made to 392d0c9. Let's revert as this change is too disruptive for a minor version (and I'm also going to replace this by a deprecation on 7.4 so that we can throw the warning in 8.0) Commits ------- 51985c9 Revert "minor #60377 [HttpFoundation] Emit PHP warning when `Response::sendHeaders()` is called while output has already been sent (ivo95v)"
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -317,11 +317,6 @@ public function sendHeaders(?int $statusCode = null): static
     {
         // headers have already been sent by the developer
         if (headers_sent()) {
-            if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg', 'embed'], true)) {
-                $statusCode ??= $this->statusCode;
-                header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);
-            }
-
             return $this;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -317,11 +317,6 @@ public function sendHeaders(?int $statusCode = null): static`
`317`	`317`	`{`
`318`	`318`	`// headers have already been sent by the developer`
`319`	`319`	`if (headers_sent()) {`
`320`		`- if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg', 'embed'], true)) {`
`321`		`- $statusCode ??= $this->statusCode;`
`322`		`- header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);`
`323`		`- }`
`324`		`-`
`325`	`320`	`return $this;`
`326`	`321`	`}`
`327`	`322`