bug #50893 [Notifier] Fix Esendex messages serialization (raphael-geffroy)

fabpot · fabpot · commit ee687df79310 · 2023-07-09T08:50:01.000+02:00
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Notifier] Fix Esendex messages serialization | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #50892 | License | MIT It seems that the "messages" is missing a dimension since 6.3 and its serialized as an object instead of an array of objects. Commits ------- 3826587 [Notifier] Fix Esendex messages serialization
diff --git a/src/Symfony/Component/Notifier/Bridge/Esendex/EsendexTransport.php b/src/Symfony/Component/Notifier/Bridge/Esendex/EsendexTransport.php
@@ -60,8 +60,10 @@ protected function doSend(MessageInterface $message): SentMessage
         $options = $message->getOptions()?->toArray() ?? [];
         $options['from'] = $message->getFrom() ?: $this->from;
         $options['messages'] = [
-            'to' => $message->getPhone(),
-            'body' => $message->getSubject(),
+            [
+                'to' => $message->getPhone(),
+                'body' => $message->getSubject(),
+            ],
         ];
         $options['accountreference'] ??= $this->accountReference;
 
diff --git a/src/Symfony/Component/Notifier/Bridge/Esendex/Tests/EsendexTransportTest.php b/src/Symfony/Component/Notifier/Bridge/Esendex/Tests/EsendexTransportTest.php
@@ -102,4 +102,38 @@ public function testSendWithSuccessfulResponseDispatchesMessageEvent()
 
         $this->assertSame($messageId, $sentMessage->getMessageId());
     }
+
+    public function testSentMessageContainsAnArrayOfMessages()
+    {
+        $messageId = bin2hex(random_bytes(7));
+        $response = $this->createMock(ResponseInterface::class);
+        $response->expects($this->exactly(2))
+            ->method('getStatusCode')
+            ->willReturn(200);
+        $response->expects($this->once())
+            ->method('getContent')
+            ->willReturn(json_encode(['batch' => ['messageheaders' => [['id' => $messageId]]]]));
+
+        $requestOptions = [];
+        $client = new MockHttpClient(static function ($method, $url, $options) use (&$requestOptions, $response): ResponseInterface {
+            $requestOptions = $options;
+
+            return $response;
+        });
+
+        $transport = self::createTransport($client);
+
+        $transport->send(new SmsMessage('phone', 'testMessage'));
+
+        $body = json_decode($requestOptions['body'] ?? '');
+
+        $messages = $body->messages;
+        $this->assertIsArray($messages);
+        $this->assertCount(1, $messages);
+
+        $message = $messages[array_key_first($messages)];
+        $this->assertIsObject($message);
+        $this->assertTrue(property_exists($message, 'to'));
+        $this->assertTrue(property_exists($message, 'body'));
+    }
 }
