feature #33540 [Serializer] Add special '*' serialization group that allows any group (nrobinaubertin)

fabpot · fabpot · commit efdc35c38714 · 2020-08-25T08:52:11.000+02:00
This PR was squashed before being merged into the 5.2-dev branch. Discussion ---------- [Serializer] Add special '*' serialization group that allows any group | Q | A | ------------- | --- | Branch? | master for features | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32622 | License | MIT | Doc PR | symfony/symfony-docs#...  Hi, I added support for a special serialization group: '*'. This group lets any group serialize the attribute marked with it. The BC break comes from the fact that someone could have used the '*' group in their code. Commits ------- 54e24a8 [Serializer] Add special '*' serialization group that allows any group
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
@@ -250,7 +250,7 @@ protected function getAllowedAttributes($classOrObject, array $context, bool $at
             // If you update this check, update accordingly the one in Symfony\Component\PropertyInfo\Extractor\SerializerExtractor::getProperties()
             if (
                 !$ignore &&
-                (false === $groups || array_intersect($attributeMetadata->getGroups(), $groups)) &&
+                (false === $groups || array_intersect(array_merge($attributeMetadata->getGroups(), ['*']), $groups)) &&
                 $this->isAllowedAttribute($classOrObject, $name = $attributeMetadata->getName(), null, $context)
             ) {
                 $allowedAttributes[] = $attributesAsString ? $name : $attributeMetadata;
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.php
@@ -72,6 +72,9 @@ public function testGetAllowedAttributesAsString()
 
         $result = $this->normalizer->getAllowedAttributes('c', [AbstractNormalizer::GROUPS => ['other']], true);
         $this->assertEquals(['a3', 'a4'], $result);
+
+        $result = $this->normalizer->getAllowedAttributes('c', [AbstractNormalizer::GROUPS => ['*']], true);
+        $this->assertEquals(['a1', 'a2', 'a3', 'a4'], $result);
     }
 
     public function testGetAllowedAttributesAsObjects()
@@ -104,6 +107,9 @@ public function testGetAllowedAttributesAsObjects()
 
         $result = $this->normalizer->getAllowedAttributes('c', [AbstractNormalizer::GROUPS => ['other']], false);
         $this->assertEquals([$a3, $a4], $result);
+
+        $result = $this->normalizer->getAllowedAttributes('c', [AbstractNormalizer::GROUPS => ['*']], false);
+        $this->assertEquals([$a1, $a2, $a3, $a4], $result);
     }
 
     public function testObjectWithStaticConstructor()
