Allow NumberToLocalizedStringTransformer empty values

gnat42 · gnat42 · commit f623d3a1eb85 · 2025-06-05T10:22:31.000-06:00
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformer.php
@@ -33,14 +33,14 @@ public function __construct(?int $scale = 2, ?bool $grouping = true, ?int $round
     /**
      * Transforms a normalized format into a localized money string.
      *
-     * @param int|float|null $value Normalized number
+     * @param int|float|string|null $value Normalized number
      *
      * @throws TransformationFailedException if the given value is not numeric or
      *                                       if the value cannot be transformed
      */
     public function transform(mixed $value): string
     {
-        if (null !== $value && 1 !== $this->divisor) {
+        if (null !== $value && '' !== $value && 1 !== $this->divisor) {
             if (!is_numeric($value)) {
                 throw new TransformationFailedException('Expected a numeric.');
             }
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
@@ -43,14 +43,14 @@ public function __construct(?int $scale = null, ?bool $grouping = false, ?int $r
     /**
      * Transforms a number type into localized number.
      *
-     * @param int|float|null $value Number value
+     * @param int|float|string|null $value Number value
      *
      * @throws TransformationFailedException if the given value is not numeric
      *                                       or if the value cannot be transformed
      */
     public function transform(mixed $value): string
     {
-        if (null === $value) {
+        if (null === $value || '' === $value) {
             return '';
         }
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformerTest.php
@@ -54,6 +54,13 @@ public function testTransformExpectsNumeric()
         $transformer->transform('abcd');
     }
 
+    public function testTransformEmptyString()
+    {
+        $transformer = new MoneyToLocalizedStringTransformer(null, null, null, 100);
+
+        $this->assertSame('', $transformer->transform(''));
+    }
+
     public function testTransformEmpty()
     {
         $transformer = new MoneyToLocalizedStringTransformer();
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
@@ -49,6 +49,7 @@ public static function provideTransformations()
     {
         return [
             [null, '', 'de_AT'],
+            ['', '', 'de_AT'],
             [1, '1', 'de_AT'],
             [1.5, '1,5', 'de_AT'],
             [1234.5, '1234,5', 'de_AT'],

Original file line number	Diff line number	Diff line change
`@@ -33,14 +33,14 @@ public function __construct(?int $scale = 2, ?bool $grouping = true, ?int $round`
`33`	`33`	`/**`
`34`	`34`	`* Transforms a normalized format into a localized money string.`
`35`	`35`	`*`
`36`		`- * @param int\|float\|null $value Normalized number`
	`36`	`+ * @param int\|float\|string\|null $value Normalized number`
`37`	`37`	`*`
`38`	`38`	`* @throws TransformationFailedException if the given value is not numeric or`
`39`	`39`	`* if the value cannot be transformed`
`40`	`40`	`*/`
`41`	`41`	`public function transform(mixed $value): string`
`42`	`42`	`{`
`43`		`- if (null !== $value && 1 !== $this->divisor) {`
	`43`	`+ if (null !== $value && '' !== $value && 1 !== $this->divisor) {`
`44`	`44`	`if (!is_numeric($value)) {`
`45`	`45`	`throw new TransformationFailedException('Expected a numeric.');`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,14 +43,14 @@ public function __construct(?int $scale = null, ?bool $grouping = false, ?int $r`
`43`	`43`	`/**`
`44`	`44`	`* Transforms a number type into localized number.`
`45`	`45`	`*`
`46`		`- * @param int\|float\|null $value Number value`
	`46`	`+ * @param int\|float\|string\|null $value Number value`
`47`	`47`	`*`
`48`	`48`	`* @throws TransformationFailedException if the given value is not numeric`
`49`	`49`	`* or if the value cannot be transformed`
`50`	`50`	`*/`
`51`	`51`	`public function transform(mixed $value): string`
`52`	`52`	`{`
`53`		`- if (null === $value) {`
	`53`	`+ if (null === $value \|\| '' === $value) {`
`54`	`54`	`return '';`
`55`	`55`	`}`
`56`	`56`
Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,13 @@ public function testTransformExpectsNumeric()`
`54`	`54`	`$transformer->transform('abcd');`
`55`	`55`	`}`
`56`	`56`
	`57`	`+ public function testTransformEmptyString()`
	`58`	`+ {`
	`59`	`+ $transformer = new MoneyToLocalizedStringTransformer(null, null, null, 100);`
	`60`	`+`
	`61`	`+ $this->assertSame('', $transformer->transform(''));`
	`62`	`+ }`
	`63`	`+`
`57`	`64`	`public function testTransformEmpty()`
`58`	`65`	`{`
`59`	`66`	`$transformer = new MoneyToLocalizedStringTransformer();`
Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ public static function provideTransformations()`
`49`	`49`	`{`
`50`	`50`	`return [`
`51`	`51`	`[null, '', 'de_AT'],`
	`52`	`+ ['', '', 'de_AT'],`
`52`	`53`	`[1, '1', 'de_AT'],`
`53`	`54`	`[1.5, '1,5', 'de_AT'],`
`54`	`55`	`[1234.5, '1234,5', 'de_AT'],`