bug #53846 [Cache] Fix BC layer with pre-6.1 cache items (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit f68d8166fb18 · 2024-02-08T15:09:20.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [Cache] Fix BC layer with pre-6.1 cache items | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53825 | License | MIT Issue introduced in #42997 Commits ------- 9372d95 [Cache] Fix BC layer with pre-6.1 cache items
diff --git a/src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php b/src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php
@@ -146,8 +146,6 @@ public function getItems(array $keys = []): iterable
         foreach ($keys as $key) {
             if ('' !== $key && \is_string($key)) {
                 $commit = $commit || isset($this->deferred[$key]);
-                $key = static::TAGS_PREFIX.$key;
-                $tagKeys[$key] = $key; // BC with pools populated before v6.1
             }
         }
 
@@ -156,7 +154,7 @@ public function getItems(array $keys = []): iterable
         }
 
         try {
-            $items = $this->pool->getItems($tagKeys + $keys);
+            $items = $this->pool->getItems($keys);
         } catch (InvalidArgumentException $e) {
             $this->pool->getItems($keys); // Should throw an exception
 
@@ -166,18 +164,24 @@ public function getItems(array $keys = []): iterable
         $bufferedItems = $itemTags = [];
 
         foreach ($items as $key => $item) {
-            if (isset($tagKeys[$key])) { // BC with pools populated before v6.1
-                if ($item->isHit()) {
-                    $itemTags[substr($key, \strlen(static::TAGS_PREFIX))] = $item->get() ?: [];
-                }
-                continue;
-            }
-
             if (null !== $tags = $item->getMetadata()[CacheItem::METADATA_TAGS] ?? null) {
                 $itemTags[$key] = $tags;
             }
 
             $bufferedItems[$key] = $item;
+
+            if (null === $tags) {
+                $key = static::TAGS_PREFIX.$key;
+                $tagKeys[$key] = $key; // BC with pools populated before v6.1
+            }
+        }
+
+        if ($tagKeys) {
+            foreach ($this->pool->getItems($tagKeys) as $key => $item) {
+                if ($item->isHit()) {
+                    $itemTags[substr($key, \strlen(static::TAGS_PREFIX))] = $item->get() ?: [];
+                }
+            }
         }
 
         $tagVersions = $this->getTagVersions($itemTags, false);
