bug #58623 [Intl] do not access typed property before initialization (xabbuh)

nicolas-grekas · nicolas-grekas · commit f69c9fd4f15e · 2024-10-22T12:31:20.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Intl] do not access typed property before initialization | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #58600 (comment) | License | MIT Commits ------- 3ca2927 do not access typed property before initialization
diff --git a/src/Symfony/Component/Intl/Tests/Transliterator/EmojiTransliteratorTest.php b/src/Symfony/Component/Intl/Tests/Transliterator/EmojiTransliteratorTest.php
@@ -177,4 +177,18 @@ public function testReverse()
         $this->expectException(\IntlException::class);
         EmojiTransliterator::create('emoji-en', EmojiTransliterator::REVERSE);
     }
+
+    public function testGetErrorCodeWithUninitializedTransliterator()
+    {
+        $transliterator = EmojiTransliterator::create('emoji-en');
+
+        $this->assertSame(0, $transliterator->getErrorCode());
+    }
+
+    public function testGetErrorMessageWithUninitializedTransliterator()
+    {
+        $transliterator = EmojiTransliterator::create('emoji-en');
+
+        $this->assertFalse($transliterator->getErrorMessage());
+    }
 }
diff --git a/src/Symfony/Component/Intl/Transliterator/EmojiTransliterator.php b/src/Symfony/Component/Intl/Transliterator/EmojiTransliterator.php
@@ -72,12 +72,12 @@ public function createInverse(): self
 
         public function getErrorCode(): int|false
         {
-            return $this->transliterator?->getErrorCode() ?? 0;
+            return isset($this->transliterator) ? $this->transliterator->getErrorCode() : 0;
         }
 
         public function getErrorMessage(): string|false
         {
-            return $this->transliterator?->getErrorMessage() ?? false;
+            return isset($this->transliterator) ? $this->transliterator->getErrorMessage() : false;
         }
 
         public static function listIDs(): array

Original file line number	Diff line number	Diff line change
`@@ -72,12 +72,12 @@ public function createInverse(): self`
`72`	`72`
`73`	`73`	`public function getErrorCode(): int\|false`
`74`	`74`	`{`
`75`		`- return $this->transliterator?->getErrorCode() ?? 0;`
	`75`	`+ return isset($this->transliterator) ? $this->transliterator->getErrorCode() : 0;`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`public function getErrorMessage(): string\|false`
`79`	`79`	`{`
`80`		`- return $this->transliterator?->getErrorMessage() ?? false;`
	`80`	`+ return isset($this->transliterator) ? $this->transliterator->getErrorMessage() : false;`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`public static function listIDs(): array`