Skip to content

Commit f7a1adb

Browse files
committed
Merge branch '2.3' into 2.5
* 2.3: fixxed order of usage [2.7] [Form] Replaced calls to array_search() by in_array() where is no need to get the index [Process] Make test AbstractProcessTest::testStartAfterATimeout useful again [Validator] Remove unnecessary include in tests [HttpFoundation] minor: clarify Request::getUrlencodedPrefix() regex fixed typo [Validator] fix DOS-style line endings [Validator] Add a Russian translation for invalid charset message [2.3] [Validator] spanish translation for invalid charset message [Routing] make host matching case-insensitive according to RFC 3986 Conflicts: src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php src/Symfony/Component/Validator/Resources/translations/validators.es.xlf src/Symfony/Component/Validator/Resources/translations/validators.ru.xlf
2 parents 45e42a8 + 1aa3768 commit f7a1adb

File tree

26 files changed

+373
-339
lines changed

26 files changed

+373
-339
lines changed

src/Symfony/Bridge/Twig/Extension/FormExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ public function humanize($text)
144144
public function isSelectedChoice(ChoiceView $choice, $selectedValue)
145145
{
146146
if (is_array($selectedValue)) {
147-
return false !== array_search($choice->value, $selectedValue, true);
147+
return in_array($choice->value, $selectedValue, true);
148148
}
149149

150150
return $choice->value === $selectedValue;

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ public function testTranslator()
246246
$this->assertEquals(array('fr'), $calls[0][1][0]);
247247
}
248248

249-
public function testTranslatorMultipleFullback()
249+
public function testTranslatorMultipleFallbacks()
250250
{
251251
$container = $this->createContainerFromFile('translator_fallbacks');
252252

src/Symfony/Component/Console/Application.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ public function getHelp()
253253
$this->getLongVersion(),
254254
'',
255255
'<comment>Usage:</comment>',
256-
' [options] command [arguments]',
256+
' command [options] [arguments]',
257257
'',
258258
'<comment>Options:</comment>',
259259
);

src/Symfony/Component/Console/Tests/Fixtures/application_1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<info>Console Tool</info>
22

33
<comment>Usage:</comment>
4-
[options] command [arguments]
4+
command [options] [arguments]
55

66
<comment>Options:</comment>
77
<info>--help</info> <info>-h</info> Display this help message

src/Symfony/Component/Console/Tests/Fixtures/application_2.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<info>My Symfony application</info> version <comment>v1.0</comment>
22

33
<comment>Usage:</comment>
4-
[options] command [arguments]
4+
command [options] [arguments]
55

66
<comment>Options:</comment>
77
<info>--help</info> <info>-h</info> Display this help message

src/Symfony/Component/Console/Tests/Fixtures/application_astext1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<info>Console Tool</info>
22

33
<comment>Usage:</comment>
4-
[options] command [arguments]
4+
command [options] [arguments]
55

66
<comment>Options:</comment>
77
<info>--help</info> <info>-h</info> Display this help message

src/Symfony/Component/Console/Tests/Fixtures/application_astext2.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<info>Console Tool</info>
22

33
<comment>Usage:</comment>
4-
[options] command [arguments]
4+
command [options] [arguments]
55

66
<comment>Options:</comment>
77
<info>--help</info> <info>-h</info> Display this help message

src/Symfony/Component/Console/Tests/Fixtures/application_gethelp.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<info>Console Tool</info>
22

33
<comment>Usage:</comment>
4-
[options] command [arguments]
4+
command [options] [arguments]
55

66
<comment>Options:</comment>
77
<info>--help</info> <info>-h</info> Display this help message

src/Symfony/Component/Console/Tests/Fixtures/application_run1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Console Tool
22

33
Usage:
4-
[options] command [arguments]
4+
command [options] [arguments]
55

66
Options:
77
--help -h Display this help message

src/Symfony/Component/Form/Extension/Core/ChoiceList/ChoiceList.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ protected function addChoice(array &$bucketForPreferred, array &$bucketForRemain
385385
*/
386386
protected function isPreferred($choice, array $preferredChoices)
387387
{
388-
return false !== array_search($choice, $preferredChoices, true);
388+
return in_array($choice, $preferredChoices, true);
389389
}
390390

391391
/**

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy