[Translation] Prevent creating empty keys when key ends with a period

javleds · javleds · commit fb42f23a6951 · 2023-10-12T18:23:46.000-06:00
[Translation] create getKeyParts() to keep periods at start or end of the key
diff --git a/src/Symfony/Component/Translation/Tests/Util/ArrayConverterTest.php b/src/Symfony/Component/Translation/Tests/Util/ArrayConverterTest.php
@@ -69,6 +69,38 @@ public static function messagesData()
                     ],
                 ],
             ],
+            [
+                // input
+                [
+                    'foo.' => 'foo.',
+                    'bar.' => 'bar.',
+                    'foo bar.' => 'foo bar.',
+                    '.foo bar' => '.foo bar',
+                    'abc 1.abc 2' => 'value',
+                    'bcd 1.bcd 2.' => 'value',
+                    '.cde 1.cde 2.' => 'value',
+                    '.def 1.def 2' => 'value',
+                ],
+                // expected output
+                [
+                    'foo.' => 'foo.',
+                    'bar.' => 'bar.',
+                    'foo bar.' => 'foo bar.',
+                    '.foo bar' => '.foo bar',
+                    'abc 1' => [
+                        'abc 2' => 'value',
+                    ],
+                    'bcd 1' => [
+                        'bcd 2.' => 'value',
+                    ],
+                    '.cde 1' => [
+                        'cde 2.' => 'value',
+                    ],
+                    '.def 1' => [
+                        'def 2' => 'value',
+                    ],
+                ],
+            ],
         ];
     }
 }
diff --git a/src/Symfony/Component/Translation/Util/ArrayConverter.php b/src/Symfony/Component/Translation/Util/ArrayConverter.php
@@ -38,7 +38,7 @@ public static function expandToTree(array $messages)
         $tree = [];
 
         foreach ($messages as $id => $value) {
-            $referenceToElement = &self::getElementByPath($tree, explode('.', $id));
+            $referenceToElement = &self::getElementByPath($tree, self::getKeyParts($id));
 
             $referenceToElement = $value;
 
@@ -65,6 +65,7 @@ private static function &getElementByPath(array &$tree, array $parts)
                 $elem = &$elem[implode('.', \array_slice($parts, $i))];
                 break;
             }
+
             $parentOfElem = &$elem;
             $elem = &$elem[$part];
         }
@@ -96,4 +97,45 @@ private static function cancelExpand(array &$tree, string $prefix, array $node)
             }
         }
     }
+
+    private static function getKeyParts(string $key)
+    {
+        $parts = explode('.', $key);
+        $partsCount = count($parts);
+
+        $result = [];
+        $buffer = '';
+
+        foreach ($parts as $index => $part) {
+            if ($index === 0 && $part === '') {
+                $buffer = '.';
+
+                continue;
+            }
+
+            if ($index === $partsCount - 1 && $part === '') {
+                $buffer .= '.';
+                $result[] = $buffer;
+
+                continue;
+            }
+
+            if (isset($parts[$index + 1]) && $parts[$index + 1] === '') {
+                $buffer .= $part;
+
+                continue;
+            }
+
+            if ($buffer) {
+                $result[] = $buffer . $part;
+                $buffer = '';
+
+                continue;
+            }
+
+            $result[] = $part;
+        }
+
+        return $result;
+    }
 }
