Apply suggestions from @nicolas-grekas

OskarStark · web-flow · commit fb64c6914016 · 2020-12-17T10:40:08.000+01:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Discord/DiscordTransport.php b/src/Symfony/Component/Notifier/Bridge/Discord/DiscordTransport.php
@@ -29,7 +29,7 @@ final class DiscordTransport extends AbstractTransport
 {
     protected const HOST = 'discord.com';
 
-    private const MAX_SUBJECT_LENGTH = 2000;
+    private const SUBJECT_LIMIT = 2000;
 
     private $token;
     private $webhookId;
@@ -67,7 +67,7 @@ protected function doSend(MessageInterface $message): SentMessage
 
         $content = $message->getSubject();
 
-        if (mb_strlen($content) > self::MAX_SUBJECT_LENGTH) {
+        if (mb_strlen($content, 'UTF-8') > self::SUBJECT_LIMIT) {
             throw new LogicException('The subject length of a Discord message must not exceed 2000 characters.');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ final class DiscordTransport extends AbstractTransport`
`29`	`29`	`{`
`30`	`30`	`protected const HOST = 'discord.com';`
`31`	`31`
`32`		`- private const MAX_SUBJECT_LENGTH = 2000;`
	`32`	`+ private const SUBJECT_LIMIT = 2000;`
`33`	`33`
`34`	`34`	`private $token;`
`35`	`35`	`private $webhookId;`
`@@ -67,7 +67,7 @@ protected function doSend(MessageInterface $message): SentMessage`
`67`	`67`
`68`	`68`	`$content = $message->getSubject();`
`69`	`69`
`70`		`- if (mb_strlen($content) > self::MAX_SUBJECT_LENGTH) {`
	`70`	`+ if (mb_strlen($content, 'UTF-8') > self::SUBJECT_LIMIT) {`
`71`	`71`	`throw new LogicException('The subject length of a Discord message must not exceed 2000 characters.');`
`72`	`72`	`}`
`73`	`73`