improve tests

HeahDude · HeahDude · commit fcb85cdd6976 · 2022-10-22T12:53:24.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/containers/container_deprecated_parameters.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/containers/container_deprecated_parameters.php
@@ -5,8 +5,7 @@
 $container = new ContainerBuilder();
 $container->setParameter('foo_class', 'FooClass\\Foo');
 $container->deprecateParameter('foo_class', 'symfony/test', '6.3');
-$container
-    ->register('foo', '%foo_class%')
+$container->register('foo', '%foo_class%')
     ->setPublic(true)
 ;
 
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php b/src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php
@@ -143,6 +143,22 @@ public function testDeprecate()
         $bag->get('foo');
     }
 
+    /**
+     * The test should be kept in the group as it always expects a deprecation.
+     *
+     * @group legacy
+     */
+    public function testDeprecateWithMessage()
+    {
+        $bag = new ParameterBag(['foo' => 'bar']);
+
+        $bag->deprecate('foo', 'symfony/test', '6.3', 'The parameter "%s" is deprecated, use "new_foo" instead.');
+
+        $this->expectDeprecation('Since symfony/test 6.3: The parameter "foo" is deprecated, use "new_foo" instead.');
+
+        $bag->get('foo');
+    }
+
     /**
      * The test should be kept in the group as it always expects a deprecation.
      *

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,7 @@`
`5`	`5`	`$container = new ContainerBuilder();`
`6`	`6`	`$container->setParameter('foo_class', 'FooClass\\Foo');`
`7`	`7`	`$container->deprecateParameter('foo_class', 'symfony/test', '6.3');`
`8`		`-$container`
`9`		`- ->register('foo', '%foo_class%')`
	`8`	`+$container->register('foo', '%foo_class%')`
`10`	`9`	`->setPublic(true)`
`11`	`10`	`;`
`12`	`11`