Request::getSession return type should not be null

| Q                | A
| ---------------- | -----
| Bug report?      | no
| Feature request? | no
| BC Break report? | no
| RFC?             | yes
| Symfony version  | 4.0

As we have a `hasSession` method:

https://github.com/symfony/symfony/blob/3e999880ed6bcf264a45c7d92080da7a671dc7d7/src/Symfony/Component/HttpFoundation/Request.php#L750-L755

IMHO, `getSession` should not be nullable for the return type:

https://github.com/symfony/symfony/blob/3e999880ed6bcf264a45c7d92080da7a671dc7d7/src/Symfony/Component/HttpFoundation/Request.php#L719-L729

It should throw an exception instead. Plus, thanks to PHP 7 type-hinting, throwing an exception will not be necessary in the future.

This will reduce some tools alerts like this:

```
Calling method set() on possibly null value of type Symfony\Component\HttpFoundation\Session\SessionInterface|null.
```

WDYT?

	* @return bool true when the Request contains a Session object, false otherwise
	*/
	public function hasSession()
	{
	return null !== $this->session;
	}

	* @return SessionInterface\|null The session
	*/
	public function getSession()
	{
	$session = $this->session;
	if (!$session instanceof SessionInterface && null !== $session) {
	$this->setSession($session = $session());
	}

	return $session;
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Request::getSession return type should not be null #26539

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Q	A
Bug report?	no
Feature request?	no
BC Break report?	no
RFC?	yes
Symfony version	4.0

Uh oh!

Request::getSession return type should not be null #26539

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.