Skip to content

ControllerTrait::getUser() remove "final" #28715

@weaverryan

Description

@weaverryan

Hi guys!

In #24407, all the controller helper methods were marked as final. I think that usually makes sense, but there is a legitimate use-case for overriding getUser(), and I do it all the time :). Specifically, I'll override getUser() to add the return type for MY User for better auto-completion:

use App\Entity\User;

public function getUser(): User
{
    return parent::getUser();
}

This is a super convenient thing to be able to do. Should we consider removing the @final?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy