Skip to content

[Lock] MongoDbStore::skimUri may strip repeated query string keys #37864

@jmikola

Description

@jmikola

Symfony version(s) affected: 5.2-dev

Description

As mentioned in https://github.com/symfony/symfony/pull/37218/files#r471609509, the current implementation of MongoDbStore::skimUri() may silently corrupt a MongoDB connection string by stripping repeated readPreferenceTags keys in a query string (permitted use case, as mentioned in the URI options spec).

How to reproduce

An example connection string is:

mongodb://rs.example.com/?readPreference=secondaryPreferred&readPreferenceTags=dc:foo&readPreferenceTags=dc:bar

After MongoDbStore::skimUri() processes this string, only a single readPreferenceTags option would remain.

Possible Solution

I think it would be preferable to capture the URI option with a regular expression and then, if anything was found, strip it from the returned string. While collection names have their own restrictions, for purposes of URI parsing I think it'd be suitable to use a pattern like /collection=([^&]*)/i (case-insensitive and only stopping at the end of a string or a & character that might precede the next key).

Additional context

Related to #37180 and corresponding PR (#37218).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy