Skip to content

[Notifier] Some Transport aren't using event dispatcher #52997

@rdavaillaud

Description

@rdavaillaud

Symfony version(s) affected

5.4, 6.4, 7.x

Description

Some Notifier transport factories are redefining the class constructor, but aren't passing the HttpClient nor the EventDispatcher.
As a result, those transports are not providing Notifier event hooks.
I think they should in order to act the same as other.

  • MercureTransportFactory
  • FakeSmsTransportFactory
  • FakeChatTransportFactory

How to reproduce

Use FakeSms bridge, and add an event listener on MessageEvent::class.

Possible Solution

PR added

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy