diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
index b21b3ee8df769..a29d8fada010a 100644
--- a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
+++ b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
@@ -339,7 +339,16 @@ private function addSessionSection(ArrayNodeDefinition $rootNode)
->children()
->scalarNode('storage_id')->defaultValue('session.storage.native')->end()
->scalarNode('handler_id')->defaultValue('session.handler.native_file')->end()
- ->scalarNode('name')->end()
+ ->scalarNode('name')
+ ->validate()
+ ->ifTrue(function ($v) {
+ parse_str($v, $parsed);
+
+ return implode('&', array_keys($parsed)) !== (string) $v;
+ })
+ ->thenInvalid('Session name %s contains illegal character(s)')
+ ->end()
+ ->end()
->scalarNode('cookie_lifetime')->end()
->scalarNode('cookie_path')->end()
->scalarNode('cookie_domain')->end()
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
index a20a120d0710b..6505d5a034932 100644
--- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
+++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
@@ -41,6 +41,55 @@ public function testDoNoDuplicateDefaultFormResources()
$this->assertEquals(array('FrameworkBundle:Form'), $config['templating']['form']['resources']);
}
+ /**
+ * @dataProvider getTestValidSessionName
+ */
+ public function testValidSessionName($sessionName)
+ {
+ $processor = new Processor();
+ $config = $processor->processConfiguration(
+ new Configuration(true),
+ array(array('session' => array('name' => $sessionName)))
+ );
+
+ $this->assertEquals($sessionName, $config['session']['name']);
+ }
+
+ public function getTestValidSessionName()
+ {
+ return array(
+ array(null),
+ array('PHPSESSID'),
+ array('a&b'),
+ array(',_-!@#$%^*(){}:<>/?'),
+ );
+ }
+
+ /**
+ * @dataProvider getTestInvalidSessionName
+ * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
+ */
+ public function testInvalidSessionName($sessionName)
+ {
+ $processor = new Processor();
+ $processor->processConfiguration(
+ new Configuration(true),
+ array(array('session' => array('name' => $sessionName)))
+ );
+ }
+
+ public function getTestInvalidSessionName()
+ {
+ return array(
+ array('a.b'),
+ array('a['),
+ array('a[]'),
+ array('a[b]'),
+ array('a=b'),
+ array('a+b'),
+ );
+ }
+
/**
* @dataProvider getTestValidTrustedProxiesData
*/
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy