From 69be8e649e95053a3f329401450b221f90395a76 Mon Sep 17 00:00:00 2001 From: Roland Franssen Date: Sun, 25 Nov 2018 08:44:16 +0100 Subject: [PATCH] [MonologBridge] Return empty list for unknonwn requests --- src/Symfony/Bridge/Monolog/Processor/DebugProcessor.php | 8 ++++---- .../Bridge/Monolog/Tests/Processor/DebugProcessorTest.php | 3 +++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Bridge/Monolog/Processor/DebugProcessor.php b/src/Symfony/Bridge/Monolog/Processor/DebugProcessor.php index a6998517e7003..6875a89f6a906 100644 --- a/src/Symfony/Bridge/Monolog/Processor/DebugProcessor.php +++ b/src/Symfony/Bridge/Monolog/Processor/DebugProcessor.php @@ -60,8 +60,8 @@ public function __invoke(array $record) */ public function getLogs(/* Request $request = null */) { - if (1 <= \func_num_args() && null !== ($request = \func_get_arg(0)) && isset($this->records[$hash = spl_object_hash($request)])) { - return $this->records[$hash]; + if (1 <= \func_num_args() && null !== $request = \func_get_arg(0)) { + return $this->records[spl_object_hash($request)] ?? array(); } if (0 === \count($this->records)) { @@ -76,8 +76,8 @@ public function getLogs(/* Request $request = null */) */ public function countErrors(/* Request $request = null */) { - if (1 <= \func_num_args() && null !== ($request = \func_get_arg(0)) && isset($this->errorCount[$hash = spl_object_hash($request)])) { - return $this->errorCount[$hash]; + if (1 <= \func_num_args() && null !== $request = \func_get_arg(0)) { + return $this->errorCount[spl_object_hash($request)] ?? 0; } return array_sum($this->errorCount); diff --git a/src/Symfony/Bridge/Monolog/Tests/Processor/DebugProcessorTest.php b/src/Symfony/Bridge/Monolog/Tests/Processor/DebugProcessorTest.php index 9acaf6074ec88..2338bc28c8fef 100644 --- a/src/Symfony/Bridge/Monolog/Tests/Processor/DebugProcessorTest.php +++ b/src/Symfony/Bridge/Monolog/Tests/Processor/DebugProcessorTest.php @@ -58,6 +58,9 @@ public function testWithRequestStack() $this->assertCount(2, $processor->getLogs($request)); $this->assertSame(1, $processor->countErrors($request)); + + $this->assertCount(0, $processor->getLogs(new Request())); + $this->assertSame(0, $processor->countErrors(new Request())); } private function getRecord($level = Logger::WARNING, $message = 'test') pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy