From af1e136ca00c90e5c2d283c608a0b94ca2c23eb9 Mon Sep 17 00:00:00 2001 From: soyuka Date: Tue, 9 Apr 2019 10:07:40 +0200 Subject: [PATCH] MetadataAwareNameConverter: Do not assume that property names are strings --- .../NameConverter/MetadataAwareNameConverter.php | 8 ++++---- .../NameConverter/MetadataAwareNameConverterTest.php | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php b/src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php index a6934f54b8181..e863e013e7582 100644 --- a/src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php +++ b/src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php @@ -69,7 +69,7 @@ public function denormalize($propertyName, string $class = null, string $format return self::$denormalizeCache[$class][$propertyName] ?? $this->denormalizeFallback($propertyName, $class, $format, $context); } - private function getCacheValueForNormalization(string $propertyName, string $class): ?string + private function getCacheValueForNormalization($propertyName, string $class) { if (!$this->metadataFactory->hasMetadataFor($class)) { return null; @@ -83,12 +83,12 @@ private function getCacheValueForNormalization(string $propertyName, string $cla return $attributesMetadata[$propertyName]->getSerializedName() ?? null; } - private function normalizeFallback(string $propertyName, string $class = null, string $format = null, array $context = []): string + private function normalizeFallback($propertyName, string $class = null, string $format = null, array $context = []) { return $this->fallbackNameConverter ? $this->fallbackNameConverter->normalize($propertyName, $class, $format, $context) : $propertyName; } - private function getCacheValueForDenormalization(string $propertyName, string $class): ?string + private function getCacheValueForDenormalization($propertyName, string $class) { if (!isset(self::$attributesMetadataCache[$class])) { self::$attributesMetadataCache[$class] = $this->getCacheValueForAttributesMetadata($class); @@ -97,7 +97,7 @@ private function getCacheValueForDenormalization(string $propertyName, string $c return self::$attributesMetadataCache[$class][$propertyName] ?? null; } - private function denormalizeFallback(string $propertyName, string $class = null, string $format = null, array $context = []): string + private function denormalizeFallback($propertyName, string $class = null, string $format = null, array $context = []) { return $this->fallbackNameConverter ? $this->fallbackNameConverter->denormalize($propertyName, $class, $format, $context) : $propertyName; } diff --git a/src/Symfony/Component/Serializer/Tests/NameConverter/MetadataAwareNameConverterTest.php b/src/Symfony/Component/Serializer/Tests/NameConverter/MetadataAwareNameConverterTest.php index f4c5c5b3059b0..7e2552ea8ac63 100644 --- a/src/Symfony/Component/Serializer/Tests/NameConverter/MetadataAwareNameConverterTest.php +++ b/src/Symfony/Component/Serializer/Tests/NameConverter/MetadataAwareNameConverterTest.php @@ -102,6 +102,7 @@ public function attributeProvider() ['foo', 'baz'], ['bar', 'qux'], ['quux', 'quux'], + [0, 0], ]; } @@ -111,6 +112,7 @@ public function fallbackAttributeProvider() ['foo', 'baz'], ['bar', 'qux'], ['quux', 'QUUX'], + [0, 0], ]; } } pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy