From c8100f34f8a3fd83ee3c127544f41219cf3a9103 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Sch=C3=A4dlich?= <jan.schaedlich@sensiolabs.de>
Date: Wed, 1 May 2019 19:29:43 +0200
Subject: [PATCH] [Validator] Improve TypeValidator to handle array of types

---
 src/Symfony/Component/Validator/CHANGELOG.md  |  5 ++
 .../Validator/Constraints/TypeValidator.php   | 27 ++++++-----
 .../Tests/Constraints/TypeValidatorTest.php   | 46 +++++++++++++++++++
 3 files changed, 66 insertions(+), 12 deletions(-)

diff --git a/src/Symfony/Component/Validator/CHANGELOG.md b/src/Symfony/Component/Validator/CHANGELOG.md
index 237dc68147b84..02e88227b7880 100644
--- a/src/Symfony/Component/Validator/CHANGELOG.md
+++ b/src/Symfony/Component/Validator/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+4.4.0
+-----
+
+ * added support for checking an array of types in `TypeValidator`
+
 4.3.0
 -----
 
diff --git a/src/Symfony/Component/Validator/Constraints/TypeValidator.php b/src/Symfony/Component/Validator/Constraints/TypeValidator.php
index 206836d3617fc..ebcf50165e14d 100644
--- a/src/Symfony/Component/Validator/Constraints/TypeValidator.php
+++ b/src/Symfony/Component/Validator/Constraints/TypeValidator.php
@@ -33,22 +33,25 @@ public function validate($value, Constraint $constraint)
             return;
         }
 
-        $type = strtolower($constraint->type);
-        $type = 'boolean' == $type ? 'bool' : $constraint->type;
-        $isFunction = 'is_'.$type;
-        $ctypeFunction = 'ctype_'.$type;
-
-        if (\function_exists($isFunction) && $isFunction($value)) {
-            return;
-        } elseif (\function_exists($ctypeFunction) && $ctypeFunction($value)) {
-            return;
-        } elseif ($value instanceof $constraint->type) {
-            return;
+        $types = (array) $constraint->type;
+
+        foreach ($types as $type) {
+            $type = strtolower($type);
+            $type = 'boolean' === $type ? 'bool' : $type;
+            $isFunction = 'is_'.$type;
+            $ctypeFunction = 'ctype_'.$type;
+            if (\function_exists($isFunction) && $isFunction($value)) {
+                return;
+            } elseif (\function_exists($ctypeFunction) && $ctypeFunction($value)) {
+                return;
+            } elseif ($value instanceof $type) {
+                return;
+            }
         }
 
         $this->context->buildViolation($constraint->message)
             ->setParameter('{{ value }}', $this->formatValue($value))
-            ->setParameter('{{ type }}', $constraint->type)
+            ->setParameter('{{ type }}', implode('|', $types))
             ->setCode(Type::INVALID_TYPE_ERROR)
             ->addViolation();
     }
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/TypeValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/TypeValidatorTest.php
index 17334bea7925a..af032ef761d16 100644
--- a/src/Symfony/Component/Validator/Tests/Constraints/TypeValidatorTest.php
+++ b/src/Symfony/Component/Validator/Tests/Constraints/TypeValidatorTest.php
@@ -163,6 +163,52 @@ public function getInvalidValues()
         ];
     }
 
+    /**
+     * @dataProvider getValidValuesMultipleTypes
+     */
+    public function testValidValuesMultipleTypes($value, array $types)
+    {
+        $constraint = new Type(['type' => $types]);
+
+        $this->validator->validate($value, $constraint);
+
+        $this->assertNoViolation();
+    }
+
+    public function getValidValuesMultipleTypes()
+    {
+        return [
+            ['12345', ['array', 'string']],
+            [[], ['array', 'string']],
+        ];
+    }
+
+    /**
+     * @dataProvider getInvalidValuesMultipleTypes
+     */
+    public function testInvalidValuesMultipleTypes($value, $types, $valueAsString)
+    {
+        $constraint = new Type([
+            'type' => $types,
+            'message' => 'myMessage',
+        ]);
+
+        $this->validator->validate($value, $constraint);
+
+        $this->buildViolation('myMessage')
+            ->setParameter('{{ value }}', $valueAsString)
+            ->setParameter('{{ type }}', implode('|', $types))
+            ->setCode(Type::INVALID_TYPE_ERROR)
+            ->assertRaised();
+    }
+
+    public function getInvalidValuesMultipleTypes()
+    {
+        return [
+            ['12345', ['boolean', 'array'], '"12345"'],
+        ];
+    }
+
     protected function createFile()
     {
         if (!static::$file) {

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/31351.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/31351.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/31351.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/31351.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>