From 7cdabd66fc429078df2a2fe86006ad178a2a05a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Deruss=C3=A9?= Date: Wed, 7 Oct 2020 23:58:16 +0200 Subject: [PATCH] Fix missing abstract arg --- .../Bundle/FrameworkBundle/Resources/config/http_client.php | 1 + .../FrameworkBundle/Resources/config/schema/symfony-1.0.xsd | 1 + .../DependencyInjection/Fixtures/php/http_client_retry.php | 1 + .../DependencyInjection/Fixtures/xml/http_client_retry.xml | 3 ++- .../DependencyInjection/Fixtures/yml/http_client_retry.yml | 1 + .../Tests/DependencyInjection/FrameworkExtensionTest.php | 1 + 6 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php index 447d07a4a1ad9..ddc5caf85a27d 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php +++ b/src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php @@ -58,6 +58,7 @@ abstract_arg('delay ms'), abstract_arg('multiplier'), abstract_arg('max delay ms'), + abstract_arg('jitter'), ]) ->set('http_client.retry.abstract_httpstatuscode_decider', HttpStatusCodeDecider::class) ->abstract() diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd b/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd index 620d065e841b6..288006092d65c 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd +++ b/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd @@ -587,6 +587,7 @@ + diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/http_client_retry.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/http_client_retry.php index eeb9e45b40fa5..8fc9e6440d7a3 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/http_client_retry.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/http_client_retry.php @@ -11,6 +11,7 @@ 'delay' => 100, 'multiplier' => 2, 'max_delay' => 0, + 'jitter' => 0.3, ] ], 'scoped_clients' => [ diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/http_client_retry.xml b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/http_client_retry.xml index 9d475da0b7edd..76004166a16b3 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/http_client_retry.xml +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/http_client_retry.xml @@ -12,7 +12,8 @@ delay="100" max-delay="0" max-retries="2" - multiplier="2"> + multiplier="2" + jitter="0.3"> 429 500 diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/http_client_retry.yml b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/http_client_retry.yml index 8b81f3d1be3bf..4cade94440d94 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/http_client_retry.yml +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/http_client_retry.yml @@ -9,6 +9,7 @@ framework: delay: 100 multiplier: 2 max_delay: 0 + jitter: 0.3 scoped_clients: foo: base_uri: http://example.com diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php index 990aa19a13506..643390fdb6ada 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php @@ -1504,6 +1504,7 @@ public function testHttpClientRetry() $this->assertSame(100, $container->getDefinition('http_client.retry.exponential_backoff')->getArgument(0)); $this->assertSame(2, $container->getDefinition('http_client.retry.exponential_backoff')->getArgument(1)); $this->assertSame(0, $container->getDefinition('http_client.retry.exponential_backoff')->getArgument(2)); + $this->assertSame(0.3, $container->getDefinition('http_client.retry.exponential_backoff')->getArgument(3)); $this->assertSame(2, $container->getDefinition('http_client.retry')->getArgument(3)); $this->assertSame(RetryableHttpClient::class, $container->getDefinition('foo.retry')->getClass()); pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy