diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
index 5d698e1da2a64..95e4a801071b8 100644
--- a/src/Symfony/Component/Filesystem/Filesystem.php
+++ b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -686,13 +686,17 @@ public function dumpFile($filename, $content)
// when the filesystem supports chmod.
$tmpFile = $this->tempnam($dir, basename($filename));
- if (false === @file_put_contents($tmpFile, $content)) {
- throw new IOException(sprintf('Failed to write file "%s".', $filename), 0, null, $filename);
- }
+ try {
+ if (false === @file_put_contents($tmpFile, $content)) {
+ throw new IOException(sprintf('Failed to write file "%s".', $filename), 0, null, $filename);
+ }
- @chmod($tmpFile, file_exists($filename) ? fileperms($filename) : 0666 & ~umask());
+ @chmod($tmpFile, file_exists($filename) ? fileperms($filename) : 0666 & ~umask());
- $this->rename($tmpFile, $filename, true);
+ $this->rename($tmpFile, $filename, true);
+ } finally {
+ @unlink($tmpFile);
+ }
}
/**
diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
index 0c012a6921746..b697d7f47898f 100644
--- a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
+++ b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
@@ -1710,6 +1710,18 @@ public function testAppendToFileCreateTheFileIfNotExists()
$this->assertStringEqualsFile($filename, 'bar');
}
+ public function testDumpRemovesTmpFilesOnFailure()
+ {
+ $expected = scandir(__DIR__, \SCANDIR_SORT_ASCENDING);
+
+ try {
+ $this->filesystem->dumpFile(__DIR__.'/Fixtures', 'bar');
+ $this->fail('IOException expected.');
+ } catch (IOException $e) {
+ $this->assertSame($expected, scandir(__DIR__, \SCANDIR_SORT_ASCENDING));
+ }
+ }
+
public function testDumpKeepsExistingPermissionsWhenOverwritingAnExistingFile()
{
$this->markAsSkippedIfChmodIsMissing();
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy