diff --git a/UPGRADE-5.3.md b/UPGRADE-5.3.md index 32615caf15b6..e6d2df5b4d9c 100644 --- a/UPGRADE-5.3.md +++ b/UPGRADE-5.3.md @@ -60,6 +60,11 @@ Messenger * Deprecated the `prefetch_count` parameter in the AMQP bridge, it has no effect and will be removed in Symfony 6.0 * Deprecated the use of TLS option for Redis Bridge, use `rediss://127.0.0.1` instead of `redis://127.0.0.1?tls=1` +Mime +---- + + * Remove the internal annotation from the `getHeaderBody()` and `getHeaderParameter()` methods of the `Headers` class. + Notifier -------- diff --git a/src/Symfony/Component/Mime/Header/Headers.php b/src/Symfony/Component/Mime/Header/Headers.php index b8d8da64f071..09d87dc570ab 100644 --- a/src/Symfony/Component/Mime/Header/Headers.php +++ b/src/Symfony/Component/Mime/Header/Headers.php @@ -254,9 +254,6 @@ public function toArray(): array return $arr; } - /** - * @internal - */ public function getHeaderBody($name) { return $this->has($name) ? $this->get($name)->getBody() : null; @@ -274,9 +271,6 @@ public function setHeaderBody(string $type, string $name, $body): void } } - /** - * @internal - */ public function getHeaderParameter(string $name, string $parameter): ?string { if (!$this->has($name)) { diff --git a/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php b/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php index f465fb9e8515..37e3192fbe94 100644 --- a/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php +++ b/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php @@ -279,4 +279,39 @@ public function testToArray() "Foo: =?utf-8?Q?aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa?=\r\n =?utf-8?Q?aaaa?=", ], $headers->toArray()); } + + public function testHeaderBody() + { + $headers = new Headers(); + $this->assertNull($headers->getHeaderBody('Content-Type')); + $headers->setHeaderBody('Text', 'Content-Type', 'type'); + $this->assertSame('type', $headers->getHeaderBody('Content-Type')); + } + + public function testHeaderParameter() + { + $headers = new Headers(); + $this->assertNull($headers->getHeaderParameter('Content-Disposition', 'name')); + + $headers->addParameterizedHeader('Content-Disposition', 'name'); + $headers->setHeaderParameter('Content-Disposition', 'name', 'foo'); + $this->assertSame('foo', $headers->getHeaderParameter('Content-Disposition', 'name')); + } + + public function testHeaderParameterNotDefined() + { + $headers = new Headers(); + + $this->expectException(\LogicException::class); + $headers->setHeaderParameter('Content-Disposition', 'name', 'foo'); + } + + public function testSetHeaderParameterNotParameterized() + { + $headers = new Headers(); + $headers->addTextHeader('Content-Disposition', 'name'); + + $this->expectException(\LogicException::class); + $headers->setHeaderParameter('Content-Disposition', 'name', 'foo'); + } }
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies: