From 2025baabba75de2837db43576a328b8311c6cd55 Mon Sep 17 00:00:00 2001
From: Jaymin G <40832979+jayminsilicon@users.noreply.github.com>
Date: Wed, 31 Jan 2024 21:26:55 +0530
Subject: [PATCH] [Console] Allow false as a $shortcut in InputOption
---
src/Symfony/Component/Console/Input/InputOption.php | 2 +-
src/Symfony/Component/Console/Tests/Input/InputOptionTest.php | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/Symfony/Component/Console/Input/InputOption.php b/src/Symfony/Component/Console/Input/InputOption.php
index 1d8dbca31021..99807f59e6ba 100644
--- a/src/Symfony/Component/Console/Input/InputOption.php
+++ b/src/Symfony/Component/Console/Input/InputOption.php
@@ -69,7 +69,7 @@ public function __construct(string $name, $shortcut = null, ?int $mode = null, s
throw new InvalidArgumentException('An option name cannot be empty.');
}
- if ('' === $shortcut || [] === $shortcut) {
+ if ('' === $shortcut || [] === $shortcut || false === $shortcut) {
$shortcut = null;
}
diff --git a/src/Symfony/Component/Console/Tests/Input/InputOptionTest.php b/src/Symfony/Component/Console/Tests/Input/InputOptionTest.php
index 55a840ac7c7a..83b295fccfcf 100644
--- a/src/Symfony/Component/Console/Tests/Input/InputOptionTest.php
+++ b/src/Symfony/Component/Console/Tests/Input/InputOptionTest.php
@@ -69,6 +69,8 @@ public function testShortcut()
$this->assertEquals('0|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in an array');
$option = new InputOption('foo', '0|z');
$this->assertEquals('0|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in a string-list');
+ $option = new InputOption('foo', false);
+ $this->assertNull($option->getShortcut(), '__construct() makes the shortcut null when given a false as value');
}
public function testModes()
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy