diff --git a/src/Symfony/Component/PropertyAccess/PropertyAccessor.php b/src/Symfony/Component/PropertyAccess/PropertyAccessor.php index 6d1ebaf1a96d..d4dbaa8bc438 100644 --- a/src/Symfony/Component/PropertyAccess/PropertyAccessor.php +++ b/src/Symfony/Component/PropertyAccess/PropertyAccessor.php @@ -640,15 +640,22 @@ private function getWriteInfo(string $class, string $property, mixed $value): Pr */ private function isPropertyWritable(object $object, string $property): bool { + if ($object instanceof \stdClass && property_exists($object, $property)) { + return true; + } + $mutatorForArray = $this->getWriteInfo($object::class, $property, []); + if (PropertyWriteInfo::TYPE_PROPERTY === $mutatorForArray->getType()) { + return $mutatorForArray->getVisibility() === 'public'; + } - if (PropertyWriteInfo::TYPE_NONE !== $mutatorForArray->getType() || ($object instanceof \stdClass && property_exists($object, $property))) { + if (PropertyWriteInfo::TYPE_NONE !== $mutatorForArray->getType()) { return true; } $mutator = $this->getWriteInfo($object::class, $property, ''); - return PropertyWriteInfo::TYPE_NONE !== $mutator->getType() || ($object instanceof \stdClass && property_exists($object, $property)); + return PropertyWriteInfo::TYPE_NONE !== $mutator->getType(); } /** diff --git a/src/Symfony/Component/PropertyAccess/Tests/Fixtures/AsymmetricVisibility.php b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/AsymmetricVisibility.php new file mode 100644 index 000000000000..5a74350b17a2 --- /dev/null +++ b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/AsymmetricVisibility.php @@ -0,0 +1,21 @@ + + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Component\PropertyAccess\Tests\Fixtures; + +class AsymmetricVisibility +{ + public public(set) mixed $publicPublic = null; + public protected(set) mixed $publicProtected = null; + public private(set) mixed $publicPrivate = null; + private private(set) mixed $privatePrivate = null; + public bool $virtualNoSetHook { get => true; } +} diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php index 9fca6f827510..d00c4e7ab461 100644 --- a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php +++ b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php @@ -20,6 +20,7 @@ use Symfony\Component\PropertyAccess\PropertyAccess; use Symfony\Component\PropertyAccess\PropertyAccessor; use Symfony\Component\PropertyAccess\PropertyAccessorInterface; +use Symfony\Component\PropertyAccess\Tests\Fixtures\AsymmetricVisibility; use Symfony\Component\PropertyAccess\Tests\Fixtures\ExtendedUninitializedProperty; use Symfony\Component\PropertyAccess\Tests\Fixtures\ReturnTyped; use Symfony\Component\PropertyAccess\Tests\Fixtures\TestAdderRemoverInvalidArgumentLength; @@ -1023,4 +1024,62 @@ private function createUninitializedObjectPropertyGhost(): UninitializedObjectPr return $class::createLazyGhost(initializer: function ($instance) { }); } + + /** + * @requires PHP 8.4 + */ + public function testIsWritableWithAsymmetricVisibility() + { + $object = new AsymmetricVisibility(); + + $this->assertTrue($this->propertyAccessor->isWritable($object, 'publicPublic')); + $this->assertFalse($this->propertyAccessor->isWritable($object, 'publicProtected')); + $this->assertFalse($this->propertyAccessor->isWritable($object, 'publicPrivate')); + $this->assertFalse($this->propertyAccessor->isWritable($object, 'privatePrivate')); + $this->assertFalse($this->propertyAccessor->isWritable($object, 'virtualNoSetHook')); + } + + /** + * @requires PHP 8.4 + */ + public function testIsReadableWithAsymmetricVisibility() + { + $object = new AsymmetricVisibility(); + + $this->assertTrue($this->propertyAccessor->isReadable($object, 'publicPublic')); + $this->assertTrue($this->propertyAccessor->isReadable($object, 'publicProtected')); + $this->assertTrue($this->propertyAccessor->isReadable($object, 'publicPrivate')); + $this->assertFalse($this->propertyAccessor->isReadable($object, 'privatePrivate')); + $this->assertTrue($this->propertyAccessor->isReadable($object, 'virtualNoSetHook')); + } + + /** + * @requires PHP 8.4 + * + * @dataProvider setValueWithAsymmetricVisibilityDataProvider + */ + public function testSetValueWithAsymmetricVisibility(string $propertyPath, ?string $expectedException) + { + $object = new AsymmetricVisibility(); + + if ($expectedException) { + $this->expectException($expectedException); + } else { + $this->expectNotToPerformAssertions(); + } + + $this->propertyAccessor->setValue($object, $propertyPath, true); + } + + /** + * @return iterable + */ + public static function setValueWithAsymmetricVisibilityDataProvider(): iterable + { + yield ['publicPublic', null]; + yield ['publicProtected', \Error::class]; + yield ['publicPrivate', \Error::class]; + yield ['privatePrivate', NoSuchPropertyException::class]; + yield ['virtualNoSetHook', \Error::class]; + } } pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy