From b8b5fb486e25808c1f6a7c0cc9790bdd17abf2d0 Mon Sep 17 00:00:00 2001
From: Christian Flothmann <christian.flothmann@qossmic.com>
Date: Thu, 2 Jan 2025 23:17:07 +0100
Subject: [PATCH] reuse the reflector tracked by the container builder

---
 .../Compiler/PriorityTaggedServiceTrait.php   | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php b/src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
index 9f443256a9405..4befef860a66e 100644
--- a/src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
+++ b/src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
@@ -64,6 +64,7 @@ private function findAndSortTaggedServices(string|TaggedIteratorArgument $tagNam
             $definition = $container->getDefinition($serviceId);
             $class = $definition->getClass();
             $class = $container->getParameterBag()->resolveValue($class) ?: null;
+            $reflector = null !== $class ? $container->getReflectionClass($class) : null;
             $checkTaggedItem = !$definition->hasTag($definition->isAutoconfigured() ? 'container.ignore_attributes' : $tagName);
 
             foreach ($attributes as $attribute) {
@@ -71,8 +72,8 @@ private function findAndSortTaggedServices(string|TaggedIteratorArgument $tagNam
 
                 if (isset($attribute['priority'])) {
                     $priority = $attribute['priority'];
-                } elseif (null === $defaultPriority && $defaultPriorityMethod && $class) {
-                    $defaultPriority = PriorityTaggedServiceUtil::getDefault($container, $serviceId, $class, $defaultPriorityMethod, $tagName, 'priority', $checkTaggedItem);
+                } elseif (null === $defaultPriority && $defaultPriorityMethod && $reflector) {
+                    $defaultPriority = PriorityTaggedServiceUtil::getDefault($serviceId, $reflector, $defaultPriorityMethod, $tagName, 'priority', $checkTaggedItem);
                 }
                 $priority ??= $defaultPriority ??= 0;
 
@@ -84,8 +85,8 @@ private function findAndSortTaggedServices(string|TaggedIteratorArgument $tagNam
                 if (null !== $indexAttribute && isset($attribute[$indexAttribute])) {
                     $index = $parameterBag->resolveValue($attribute[$indexAttribute]);
                 }
-                if (null === $index && null === $defaultIndex && $defaultPriorityMethod && $class) {
-                    $defaultIndex = PriorityTaggedServiceUtil::getDefault($container, $serviceId, $class, $defaultIndexMethod ?? 'getDefaultName', $tagName, $indexAttribute, $checkTaggedItem);
+                if (null === $index && null === $defaultIndex && $defaultPriorityMethod && $reflector) {
+                    $defaultIndex = PriorityTaggedServiceUtil::getDefault($serviceId, $reflector, $defaultIndexMethod ?? 'getDefaultName', $tagName, $indexAttribute, $checkTaggedItem);
                 }
                 $decorated = $definition->getTag('container.decorator')[0]['id'] ?? null;
                 $index = $index ?? $defaultIndex ?? $defaultIndex = $decorated ?? $serviceId;
@@ -93,8 +94,8 @@ private function findAndSortTaggedServices(string|TaggedIteratorArgument $tagNam
                 $services[] = [$priority, ++$i, $index, $serviceId, $class];
             }
 
-            if ($class) {
-                $attributes = (new \ReflectionClass($class))->getAttributes(AsTaggedItem::class);
+            if ($reflector) {
+                $attributes = $reflector->getAttributes(AsTaggedItem::class);
                 $attributeCount = \count($attributes);
 
                 foreach ($attributes as $attribute) {
@@ -137,9 +138,11 @@ private function findAndSortTaggedServices(string|TaggedIteratorArgument $tagNam
  */
 class PriorityTaggedServiceUtil
 {
-    public static function getDefault(ContainerBuilder $container, string $serviceId, string $class, string $defaultMethod, string $tagName, ?string $indexAttribute, bool $checkTaggedItem): string|int|null
+    public static function getDefault(string $serviceId, \ReflectionClass $r, string $defaultMethod, string $tagName, ?string $indexAttribute, bool $checkTaggedItem): string|int|null
     {
-        if (!($r = $container->getReflectionClass($class)) || (!$checkTaggedItem && !$r->hasMethod($defaultMethod))) {
+        $class = $r->getName();
+
+        if (!$checkTaggedItem && !$r->hasMethod($defaultMethod)) {
             return null;
         }
 

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/59350.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/59350.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/59350.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/59350.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>