From 1b78fb41eaf69a2dfe497f9bdfe1dc6315a353ab Mon Sep 17 00:00:00 2001
From: Santiago San Martin <sanmartindev@gmail.com>
Date: Mon, 30 Jun 2025 22:05:23 -0300
Subject: [PATCH] [Translation] not mock class `DataCollectorTranslator` in
 test `TranslationDataCollectorTest`

---
 .../TranslationDataCollectorTest.php          | 38 +++++++++----------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/src/Symfony/Component/Translation/Tests/DataCollector/TranslationDataCollectorTest.php b/src/Symfony/Component/Translation/Tests/DataCollector/TranslationDataCollectorTest.php
index 64af1284c21e8..46bc404f7f9cb 100644
--- a/src/Symfony/Component/Translation/Tests/DataCollector/TranslationDataCollectorTest.php
+++ b/src/Symfony/Component/Translation/Tests/DataCollector/TranslationDataCollectorTest.php
@@ -11,20 +11,23 @@
 
 namespace Symfony\Component\Translation\Tests\DataCollector;
 
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Translation\DataCollector\TranslationDataCollector;
 use Symfony\Component\Translation\DataCollectorTranslator;
+use Symfony\Component\Translation\Translator;
 
 class TranslationDataCollectorTest extends TestCase
 {
     public function testCollectEmptyMessages()
     {
-        $translator = $this->getTranslator();
-        $translator->expects($this->any())->method('getCollectedMessages')->willReturn([]);
+        /** @var Translator&MockObject $translator */
+        $translator = $this->createMock(Translator::class);
+        $dataCollectorTranslator = new DataCollectorTranslator($translator);
 
-        $dataCollector = new TranslationDataCollector($translator);
+        $dataCollector = new TranslationDataCollector($dataCollectorTranslator);
         $dataCollector->lateCollect();
 
         $this->assertEquals(0, $dataCollector->getCountMissings());
@@ -119,10 +122,15 @@ public function testCollect()
             ],
         ];
 
-        $translator = $this->getTranslator();
-        $translator->expects($this->any())->method('getCollectedMessages')->willReturn($collectedMessages);
+        /** @var Translator&MockObject $translator */
+        $translator = $this->createMock(Translator::class);
+        $dataCollectorTranslator = new DataCollectorTranslator($translator);
 
-        $dataCollector = new TranslationDataCollector($translator);
+        $reflection = new \ReflectionClass($dataCollectorTranslator);
+        $property = $reflection->getProperty('messages');
+        $property->setValue($dataCollectorTranslator, $collectedMessages);
+
+        $dataCollector = new TranslationDataCollector($dataCollectorTranslator);
         $dataCollector->lateCollect();
 
         $this->assertEquals(1, $dataCollector->getCountMissings());
@@ -134,12 +142,15 @@ public function testCollect()
 
     public function testCollectAndReset()
     {
-        $translator = $this->getTranslator();
+        /** @var Translator&MockObject $translator */
+        $translator = $this->createMock(Translator::class);
         $translator->method('getLocale')->willReturn('fr');
         $translator->method('getFallbackLocales')->willReturn(['en']);
         $translator->method('getGlobalParameters')->willReturn(['welcome' => 'Welcome {name}!']);
 
-        $dataCollector = new TranslationDataCollector($translator);
+        $dataCollectorTranslator = new DataCollectorTranslator($translator);
+
+        $dataCollector = new TranslationDataCollector($dataCollectorTranslator);
         $dataCollector->collect($this->createMock(Request::class), $this->createMock(Response::class));
 
         $this->assertSame('fr', $dataCollector->getLocale());
@@ -152,15 +163,4 @@ public function testCollectAndReset()
         $this->assertSame([], $dataCollector->getFallbackLocales());
         $this->assertSame([], $dataCollector->getGlobalParameters());
     }
-
-    private function getTranslator()
-    {
-        $translator = $this
-            ->getMockBuilder(DataCollectorTranslator::class)
-            ->disableOriginalConstructor()
-            ->getMock()
-        ;
-
-        return $translator;
-    }
 }

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/61000.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/61000.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/61000.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/61000.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>