[Cache] RedisTrait::doFetch should use pipeline with GET's instead of MGET for Relay\Cluster #61234
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 29, 2025
f4fad81 to
b74ec69
Compare
|
@nicolas-grekas done, I have dropped the commit which applied the diff from Fabbot. 👍 The only reason I included them originally was to make those checks pass. |
b74ec69 to
30a2ca0
Compare
|
Thank you @dorrogeray. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️
Relay\Clustershould be expected to operate with >1 master nodes, and therefore its not safe to usemgetwhen fetching the ids inRedisTrait::doFetch(array $ids)as they are not guaranteed to be on a same hash slot.This change makes
doFetchuse pipeline withGETcommands when$this->redis instanceof RelayCluster