Skip to content

Commit 0e288a2

Browse files
gondoxabbuh
authored andcommitted
removed unnecesary exception form repository
removed `UsernameNotFoundException` form repository as this logic does not belong to repository and also it is duplicated. exception is already thrown on proper place if no user is found: https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/Security/User/EntityUserProvider.php#L60
1 parent ab57eed commit 0e288a2

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

cookbook/security/entity_provider.rst

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -432,29 +432,18 @@ interface only requires one method: ``loadUserByUsername($username)``::
432432

433433
use Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface;
434434
use Symfony\Component\Security\Core\User\UserInterface;
435-
use Symfony\Component\Security\Core\Exception\UsernameNotFoundException;
436435
use Doctrine\ORM\EntityRepository;
437436

438437
class UserRepository extends EntityRepository implements UserLoaderInterface
439438
{
440439
public function loadUserByUsername($username)
441440
{
442-
$user = $this->createQueryBuilder('u')
441+
return $this->createQueryBuilder('u')
443442
->where('u.username = :username OR u.email = :email')
444443
->setParameter('username', $username)
445444
->setParameter('email', $username)
446445
->getQuery()
447446
->getOneOrNullResult();
448-
449-
if (null === $user) {
450-
$message = sprintf(
451-
'Unable to find an active admin AppBundle:User object identified by "%s".',
452-
$username
453-
);
454-
throw new UsernameNotFoundException($message);
455-
}
456-
457-
return $user;
458447
}
459448
}
460449

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy