minor #17452 Fix confusing example of type-hinting the Request object (theofidry)

javiereguiluz · javiereguiluz · commit 5ca91b62b022 · 2022-11-21T17:38:36.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- Fix confusing example of type-hinting the Request object As far as I can see, this piece of doc is incorrect as `$firstName` and `$lastName` wouldn't be injected properly there and the piece of doc in question is not about those two parameters either. As such I propose to remove them from the example to prevent any confusion. Commits ------- 4351c89 Fix bad copy/paste
diff --git a/controller.rst b/controller.rst
@@ -381,7 +381,7 @@ object. To access it in your controller, add it as an argument and
     use Symfony\Component\HttpFoundation\Response;
     // ...
 
-    public function index(Request $request, string $firstName, string $lastName): Response
+    public function index(Request $request): Response
     {
         $page = $request->query->get('page', 1);
 

Original file line number	Diff line number	Diff line change
`@@ -381,7 +381,7 @@ object. To access it in your controller, add it as an argument and`
`381`	`381`	`use Symfony\Component\HttpFoundation\Response;`
`382`	`382`	`// ...`
`383`	`383`
`384`		`- public function index(Request $request, string $firstName, string $lastName): Response`
	`384`	`+ public function index(Request $request): Response`
`385`	`385`	`{`
`386`	`386`	`$page = $request->query->get('page', 1);`
`387`	`387`