minor #10810 [Validator] Explained how to use array constant in annotation (nikophil)

javiereguiluz · javiereguiluz · commit 687d345b638c · 2019-03-07T17:44:12.000+01:00
This PR was squashed before being merged into the 3.4 branch (closes #10810). Discussion ---------- [Validator] Explained how to use array constant in annotation Hi, few days ago i tried to add a new feature to the `choice` validator constraint, by adding a new `choicesFromConstant` option. symfony/symfony#29658 But then, i realized this was already supported. I think this should be documented, as i think a lot of people don't know this feature. thanks. Commits ------- 7774aab [Validator] Explained how to use array constant in annotation
diff --git a/reference/constraints/Choice.rst b/reference/constraints/Choice.rst
@@ -47,13 +47,17 @@ If your valid choice list is simple, you can pass them in directly via the
 
         class Author
         {
+            const GENRES = ['fiction', 'non-fiction'];
+
             /**
              * @Assert\Choice({"New York", "Berlin", "Tokyo"})
              */
             protected $city;
 
             /**
-             * @Assert\Choice(choices={"fiction", "non-fiction"}, message="Choose a valid genre.")
+             * You can also directly provide an array constant to the "choices" option in the annotation
+             *
+             * @Assert\Choice(choices=Author::GENRES, message="Choose a valid genre.")
              */
             protected $genre;
         }
@@ -211,7 +215,7 @@ constraint.
             }
         }
 
-If the callback is stored in a different class and is static, for example ``AppBundle\Entity\Genre``,
+If the callback is defined in a different class and is static, for example ``AppBundle\Entity\Genre``,
 you can pass the class name and the method as an array.
 
 .. configuration-block::

Original file line number	Diff line number	Diff line change
`@@ -47,13 +47,17 @@ If your valid choice list is simple, you can pass them in directly via the`
`47`	`47`
`48`	`48`	`class Author`
`49`	`49`	`{`
	`50`	`+ const GENRES = ['fiction', 'non-fiction'];`
	`51`	`+`
`50`	`52`	`/**`
`51`	`53`	`* @Assert\Choice({"New York", "Berlin", "Tokyo"})`
`52`	`54`	`*/`
`53`	`55`	`protected $city;`
`54`	`56`
`55`	`57`	`/**`
`56`		`- * @Assert\Choice(choices={"fiction", "non-fiction"}, message="Choose a valid genre.")`
	`58`	`+ * You can also directly provide an array constant to the "choices" option in the annotation`
	`59`	`+ *`
	`60`	`+ * @Assert\Choice(choices=Author::GENRES, message="Choose a valid genre.")`
`57`	`61`	`*/`
`58`	`62`	`protected $genre;`
`59`	`63`	`}`
`@@ -211,7 +215,7 @@ constraint.`
`211`	`215`	`}`
`212`	`216`	`}`
`213`	`217`
`214`		-If the callback is stored in a different class and is static, for example ``AppBundle\Entity\Genre``,
	`218`	+If the callback is defined in a different class and is static, for example ``AppBundle\Entity\Genre``,
`215`	`219`	`you can pass the class name and the method as an array.`
`216`	`220`
`217`	`221`	`.. configuration-block::`